Revert "scheduler: pick vf by random (#1953)"#1986
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Apr 9, 2024
Merged
Revert "scheduler: pick vf by random (#1953)"#1986koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Member
|
/lgtm |
ZiMengSheng
force-pushed
the
vfradn
branch
2 times, most recently
from
1cdf019 to
de4ee49
Compare
This reverts commit beaafa3. Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
- Coverage 68.67% 68.64% -0.03%
==========================================
Files 421 421
Lines 38779 38778 -1
==========================================
- Hits 26632 26621 -11
- Misses 9835 9845 +10
Partials 2312 2312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
georgexiang
pushed a commit
to ocichina/koordinator
that referenced
this pull request
Apr 15, 2024
…tor-sh#1986) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Signed-off-by: george <xiangzhihua@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit beaafa3.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test