-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(components): dynamically compute expected value in Profile Controller: Fixes #11828 #11849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Gabriel Rudloff <[email protected]>
|
Hi @grudloffev. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
@grudloffev can you please link the PR to the issue? |
|
@hbelmiro done 👌 |
|
FYI this has been tested in my environment, without any issues so far. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
Not sure about the failing test here, in the other PR -which builds on this- all tests are passing |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Gabriel Rudloff <[email protected]>
|
The error is the same for all retests so it doesn't seem like flakiness. There is a difference with the implementation from the other PR, which may be the reason for the error, also rebased again just in case. |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
Description of your changes:
This pull request addresses issue #11828 regarding hardcoded values in the Profile Controller
sync.pyfor each type of component. The changes involve dynamically computing the expected values from thedesired_resourceslist. This enhancement allows for easier customization of the file, enabling users to add additional resources by default for each user namespace without manually modifying hardcoded values.Fixes #11828
Checklist: