Skip to content

Conversation

@grudloffev
Copy link

@grudloffev grudloffev commented Apr 23, 2025

Description of your changes:

This pull request addresses issue #11828 regarding hardcoded values in the Profile Controller sync.py for each type of component. The changes involve dynamically computing the expected values from the desired_resources list. This enhancement allows for easier customization of the file, enabling users to add additional resources by default for each user namespace without manually modifying hardcoded values.

Fixes #11828

Checklist:

Signed-off-by: Gabriel Rudloff <[email protected]>
@google-oss-prow
Copy link

Hi @grudloffev. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

@grudloffev can you please link the PR to the issue?

@grudloffev
Copy link
Author

@hbelmiro done 👌

@grudloffev
Copy link
Author

FYI this has been tested in my environment, without any issues so far.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

hbelmiro commented Jun 4, 2025

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Approvals successfully granted for pending runs.

@grudloffev
Copy link
Author

grudloffev commented Jun 5, 2025

Not sure about the failing test here, in the other PR -which builds on this- all tests are passing

@hbelmiro
Copy link
Contributor

hbelmiro commented Jun 5, 2025

/retest

1 similar comment
@hbelmiro
Copy link
Contributor

hbelmiro commented Jun 5, 2025

/retest

@grudloffev
Copy link
Author

The error is the same for all retests so it doesn't seem like flakiness. There is a difference with the implementation from the other PR, which may be the reason for the error, also rebased again just in case.

@hbelmiro
Copy link
Contributor

hbelmiro commented Jun 6, 2025

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

Approvals successfully granted for pending runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Remove hardcoded values from Pipelines Controller´s sync.py

2 participants