feat(component): Refactors sync.py to use json templates for resources. Fixes #11851

[grudloffev]

Description of your changes:

This PR introduces a refactor to the sync.py file, making the loading of the desired resources completely dynamic by reading the list of resources from a template json file. Moreover, an additional template (empty by default) is also available to pass additional resources in case one would like to do so with kustomize.

Fixes #11851

How is this achieved?

• The desired_resources object is populated through a function, which reads the resources from json templates, where variables to be replaced are indicated with double curly braces.
• The templates are mounted jointly with the sync.py via a ConfigMap.
• This PR builds on top of feat(components): dynamically compute expected value in Profile Controller: Fixes #11828 #11849, and therefore the expected numbers for each kind of resources are not hardcoded and are computed dynamically from desired_resources.

Checklist:

• You have signed off your commits
• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-oss-prow]

Hi @grudloffev. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

🚫 This command cannot be processed. Only organization members or owners can use the commands.

[grudloffev]

Changes to WIP, as fixing the test has not been done yet.

[grudloffev]

All tests are failing on current main branch😞

• Dependency issue feat(backend/sdk): add backend support for toleration lists. #11860
• Even after addressing the above issue, all tests are still failing. I am guessing this may be related to the latest changes to sync.py introduced with fix(manifests): Upgrading metacontroller to v4.11.22 #11656

[grudloffev]

Confirmed regression source by rolling back to a6b944b894a4a297a6310f5028a8c27e3603ac16 (Commit before the metacontroller update) and then rolling forward to ebaaf756319ac4ac9498aca5f7dfb3978ff36496 (Metacontroller update), and on the former all tests pass while on the later they all fail.

[grudloffev]

Tests are passing now

[grudloffev]

Fixes #11859

[hbelmiro]

/ok-to-test

[hbelmiro]

@grudloffev Can you please sign off your commits?

[grudloffev]

@grudloffev Can you please sign off your commits?

My bad, I missed one. I think it is good now

[hbelmiro]

/ok-to-test

[hbelmiro]

/unhold

[github-actions]

Approvals successfully granted for pending runs.

[grudloffev]

related issue #10904

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• manifests/kustomize/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hbelmiro]

/ok-to-test

[github-actions]

Approvals successfully granted for pending runs.

[hbelmiro]

/ok-to-test

[github-actions]

Approvals successfully granted for pending runs.