feat(backend/sdk): add backend support for toleration lists. #11860
Conversation
HumairAK
force-pushed
the
support_toleration_list
branch
from
8a0e290 to
296f580
Compare
HumairAK
force-pushed
the
support_toleration_list
branch
from
296f580 to
f41dd51
Compare
| Returns: | ||
| Task object with added toleration. | ||
| """ | ||
| if not isinstance(toleration_json, pipeline_channel.PipelineParameterChannel): | ||
| raise TypeError("toleration_json must be a Pipeline Input Parameter.") |
There was a problem hiding this comment.
Why is this required? It seems reasonable to allow static values.
There was a problem hiding this comment.
this one we can discuss but currently the support is only for pipelienparameter channels and the check is protecting the user from making a mistake only recognizable during runtime (without this), if you are provided hardcoded values then add_toleration() is largely sufficient for most needs even list of dicts, adding support for static list/dicts is out of scope, but I'd be happy to add this in a follow up if we want to go that route
There was a problem hiding this comment.
added support for static list/dicts. One caveat here is that the pipeline spec yaml only will utilize the toleration_json for input parameter under the hood, since this isn't used for add_toleration.
clarify toleration json docs Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
support_toleration_list
branch
from
f41dd51 to
b083e6b
Compare
Signed-off-by: Humair Khan <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
the e2e and frontend failures are unrelated and are being addressed in other prs, going to bypass merge this for now, we're actively working on a fix for the CI else where, see #11864 |
It is a very reasonable usecase the user may want to provide as input a list of tolerations instead of a single toleration object. In fact, it is probably more preferable that we don't foce the user to add a new input for each new toleration entry for one of more tasks. This PR makes it so the input tolerations_json call will accept both, either a single or list of toleration input parameters. All tolerations, whether hardcoded, input list, input dicts, are appeneded into a flat list by driver.
Checklist: