Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

update api version & glog -> klog #42

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

wlan0
Copy link
Contributor

@wlan0 wlan0 commented Mar 15, 2021

updates to latest api version and uses structured logging using klog

@krishchow @brahmaroutu @jeffvance

@wlan0 wlan0 requested a review from brahmaroutu March 15, 2021 04:08
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2021
Copy link

@krishchow krishchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why the tests are failing though

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishchow, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffvance
Copy link

From build log:

# github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/bucketrequest [github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/bucketrequest.test]
pkg/bucketrequest/bucketrequest_test.go:89:14: undefined: NewListener
pkg/bucketrequest/bucketrequest_test.go:132:14: undefined: NewListener
pkg/bucketrequest/bucketrequest_test.go:186:14: undefined: NewListener
note: module requires Go 1.15
ok  	github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/bucketaccessrequest	0.258s
FAIL	github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/bucketrequest [build failed]
?   	github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/util	[no test files]
?   	github.com/kubernetes-sigs/container-object-storage-interface-controller/release-tools	[no test files]
FAIL
make: *** [release-tools/build.make:110: test-go] Error 2

@wlan0 wlan0 force-pushed the api-klog-update branch from 9acee62 to 81a60fb Compare March 17, 2021 18:42
@wlan0 wlan0 force-pushed the api-klog-update branch from 81a60fb to ca40b1d Compare March 17, 2021 18:45
@brahmaroutu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit a937f42 into kubernetes-retired:master Mar 17, 2021
@wlan0 wlan0 deleted the api-klog-update branch March 17, 2021 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants