🐛 Specify controller manager broadcaster options so events do not get discarded#1124
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Sep 30, 2019
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
Contributor
Author
|
heads up to reviewers: I am on holiday until September 25th. If you have feedback, feel free to cherry-pick this branch! |
detiber
reviewed
Sep 11, 2019
Contributor
detiber
left a comment
detiber
left a comment
There was a problem hiding this comment.
Some nits on the go.mod changes, otherwise this looks great :)
Contributor
|
@detiber do you want to merge & then do a follow-up, or close and open a replacement? |
ncdc
reviewed
Sep 12, 2019
liztio
force-pushed
the
disable-event-throttling
branch
from
c538606 to
89bea5b
Compare
k8s-ci-robot
added
needs-rebase
liztio
force-pushed
the
disable-event-throttling
branch
from
89bea5b to
b98d3ef
Compare
k8s-ci-robot
removed
the
needs-rebase
vincepri
reviewed
Sep 27, 2019
liztio
force-pushed
the
disable-event-throttling
branch
9 times, most recently
from
55980f6 to
d144d60
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liztio, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ncdc
reviewed
Sep 27, 2019
liztio
force-pushed
the
disable-event-throttling
branch
from
d144d60 to
4b22bf9
Compare
k8s-ci-robot
added
the
lgtm
vincepri
changed the title
vincepri
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we are losing deletion events if they occur soon after cluster creation, and possibly other events we don't know about. This ups the limits of events reported in a given window so all events are submitted to the Kubernetes API.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1068