✨ expose NewResourceLock in manager.Options

[jzhoucliqr]

This is to enable controllers to use customized resource locks for leader election.

It is for the use case that a standalone aggregation-like apiserver running without native kube-apiserver, thus the corev1 resources are not available through apiserver REST API.

With this, Mangers can use customized resourceLocks, without relying on corev1 resources.

Closes #534

[k8s-ci-robot]

Welcome @jzhoucliqr!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jzhoucliqr
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jzhoucliqr]

/retest

[k8s-ci-robot]

@jzhoucliqr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jzhoucliqr]

@DirectXMan12 @pwittrock Do you have time to take a quick look at this PR? Thanks.

[DirectXMan12]

I'm not sure this is the interface we want to expose -- the particulars of the resource lock are mainly an implementation detail at this point, and this adds yet another piece of client-go to our public API, which increases the chance that things will arbitrarily break in the future.

That being said, I'll have to take a closer look to see what our options are.

[DirectXMan12]

closing in favor of #600