-
Notifications
You must be signed in to change notification settings - Fork 277
test: added latency predictor converage for inferencepool and added convera… #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 9 commits into
kubernetes-sigs:main
from
capri-xiyue:capri-xiyue/2173
Jan 21, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d42f2fd
added latency predictor converage for inferencepool and added convera…
capri-xiyue f45b208
fixd ci cd
capri-xiyue 4cf13ac
added existance check
capri-xiyue ac0e7cb
added existence check
capri-xiyue 6571281
added latency predictor value
capri-xiyue b4207d5
added prediction value.yaml
capri-xiyue b2ba12a
added comments
capri-xiyue 974aa3b
added alias in epp-standalone
capri-xiyue b7c0e8a
added comment
capri-xiyue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| latencyPredictor: | ||
| enabled: false | ||
| # Training Server Configuration | ||
| trainingServer: | ||
| image: | ||
| hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars | ||
| name: latencypredictor-training-server | ||
| tag: latest | ||
| pullPolicy: Always | ||
| port: 8000 | ||
| resources: | ||
| requests: | ||
| cpu: "2000m" | ||
| memory: "4Gi" | ||
| limits: | ||
| cpu: "4000m" | ||
| memory: "8Gi" | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| port: 8000 | ||
| initialDelaySeconds: 30 | ||
| periodSeconds: 20 | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /readyz | ||
| port: 8000 | ||
| initialDelaySeconds: 45 | ||
| periodSeconds: 10 | ||
| volumeSize: "20Gi" | ||
| config: | ||
| LATENCY_RETRAINING_INTERVAL_SEC: "1" | ||
| LATENCY_MIN_SAMPLES_FOR_RETRAIN: "100" | ||
| LATENCY_TTFT_MODEL_PATH: "/models/ttft.joblib" | ||
| LATENCY_TPOT_MODEL_PATH: "/models/tpot.joblib" | ||
| LATENCY_TTFT_SCALER_PATH: "/models/ttft_scaler.joblib" | ||
| LATENCY_TPOT_SCALER_PATH: "/models/tpot_scaler.joblib" | ||
| LATENCY_MODEL_TYPE: "xgboost" | ||
| LATENCY_MAX_TRAINING_DATA_SIZE_PER_BUCKET: "5000" | ||
| LATENCY_QUANTILE_ALPHA: "0.9" | ||
|
|
||
| # Prediction Server Configuration | ||
| predictionServers: | ||
| count: 10 | ||
| startPort: 8001 | ||
| image: | ||
| hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars | ||
| name: latencypredictor-prediction-server | ||
| tag: latest | ||
| pullPolicy: Always | ||
| resources: | ||
| requests: | ||
| cpu: "500m" | ||
| memory: "1Gi" | ||
| limits: | ||
| cpu: "1000m" | ||
| memory: "2Gi" | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| initialDelaySeconds: 15 | ||
| periodSeconds: 15 | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /readyz | ||
| initialDelaySeconds: 10 | ||
| periodSeconds: 5 | ||
| failureThreshold: 10 | ||
| volumeSize: "10Gi" | ||
| config: | ||
| LATENCY_MODEL_TYPE: "xgboost" | ||
| PREDICT_HOST: "0.0.0.0" | ||
| LOCAL_TTFT_MODEL_PATH: "/server_models/ttft.joblib" | ||
| LOCAL_TPOT_MODEL_PATH: "/server_models/tpot.joblib" | ||
| LOCAL_TTFT_SCALER_PATH: "/server_models/ttft_scaler.joblib" | ||
| LOCAL_TPOT_SCALER_PATH: "/server_models/tpot_scaler.joblib" | ||
|
|
||
| # EPP Environment Variables for Latency Predictor | ||
| eppEnv: | ||
| LATENCY_MAX_SAMPLE_SIZE: "10000" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a bug?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously in inferencepool helm chart, as the values.yaml provides a none as a default, we won't have issues. But in epp-standalone helm chart, the default "none" was not provided. Therefore, it will encounter issue. I've made default "none" in this PR and here check provider exists before before accessing the value(more defensive). I was testing "gke" set up, therefore didn't notice this when there was no provider value.