test: added latency predictor converage for inferencepool and added convera… by capri-xiyue · Pull Request #2187 · kubernetes-sigs/gateway-api-inference-extension

capri-xiyue · 2026-01-20T19:43:29Z

…ge for epp standalone mode

What type of PR is this?

/kind test

What this PR does / why we need it:
Added test coverage for inferencepool with latency predictor and test converage for epp standalone mode

Which issue(s) this PR fixes:

Fixes #2173

Does this PR introduce a user-facing change?:

NONE

…ge for epp standalone mode

k8s-ci-robot · 2026-01-20T19:43:32Z

@capri-xiyue: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

…ge for epp standalone mode

What type of PR is this?

/kind test
What this PR does / why we need it:
Added test coverage for inferencepool with latency predictor and test converage for epp standalone mode

Which issue(s) this PR fixes:

Fixes #2173

Does this PR introduce a user-facing change?:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2026-01-20T19:43:37Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`b7c0e8a`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69711b6a5a39cf0008b473e1
😎 Deploy Preview	https://deploy-preview-2187--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

capri-xiyue · 2026-01-20T21:38:13Z

/assign @zetxqx

capri-xiyue · 2026-01-20T21:38:21Z

assign @ahg-g

ahg-g · 2026-01-21T10:43:54Z

config/charts/epp-standalone/values.yaml

+    # Training Server Configuration
+    trainingServer:
+      image:
+        hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars


@kaushikmitr we don't have a released image?

no just created an issue: #2241

config/charts/epp-standalone/values.yaml

ahg-g · 2026-01-21T10:45:50Z

config/charts/inference-extension/templates/_gke.yaml

@@ -1,5 +1,5 @@
 {{- define "inference-extension.gke" -}}
-{{- if eq (lower .Values.provider.name) "gke" }}
+{{- if and .Values.provider (eq (lower .Values.provider.name) "gke") }}


was this a bug?

Previously in inferencepool helm chart, as the values.yaml provides a none as a default, we won't have issues. But in epp-standalone helm chart, the default "none" was not provided. Therefore, it will encounter issue. I've made default "none" in this PR and here check provider exists before before accessing the value(more defensive). I was testing "gke" set up, therefore didn't notice this when there was no provider value.

ahg-g · 2026-01-21T18:55:32Z

why do we have a test as a prefix to the PR title?

capri-xiyue · 2026-01-21T18:58:23Z

why do we have a test as a prefix?

@ahg-g
I thought this is the convention see #2175
If the PR is related to test, add "test" as a prefix.
If it is a new feature, add "feat"
If it is a doc, add "docs"
I think such verify script works as a test purpose to verify our helm chart works as expected.

ahg-g · 2026-01-21T19:02:21Z

I am not aware of that convention :)

But also, isn't the primary purpose of this PR is adding the latency predictor to the standalone?

capri-xiyue · 2026-01-21T19:04:58Z

I am not aware of that convention :)

But also, isn't the primary purpose of this PR is adding the latency predictor to the standalone?

My primary purpose is to add helm template coverage to both inferencepool helm chart and epp standalone chart.

ahg-g · 2026-01-21T19:07:14Z

/lgtm
/approve

k8s-ci-robot · 2026-01-21T19:07:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

added latency predictor converage for inferencepool and added convera…

d42f2fd

…ge for epp standalone mode

k8s-ci-robot requested review from liu-cong and nirrozenbaum January 20, 2026 19:43

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2026

capri-xiyue changed the title ~~test: added latency predictor converage for inferencepool and added convera…~~ feat: added latency predictor converage for inferencepool and added convera… Jan 20, 2026

capri-xiyue changed the title ~~feat: added latency predictor converage for inferencepool and added convera…~~ test: added latency predictor converage for inferencepool and added convera… Jan 20, 2026

capri-xiyue added 3 commits January 20, 2026 11:58

fixd ci cd

f45b208

added existance check

4cf13ac

added existence check

ac0e7cb

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2026

added latency predictor value

6571281

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2026

k8s-ci-robot assigned zetxqx Jan 20, 2026

ahg-g reviewed Jan 21, 2026

View reviewed changes

capri-xiyue requested a review from zetxqx January 21, 2026 18:02

capri-xiyue added 4 commits January 21, 2026 10:26

added prediction value.yaml

b4207d5

added comments

b2ba12a

added alias in epp-standalone

974aa3b

added comment

b7c0e8a

capri-xiyue requested a review from ahg-g January 21, 2026 18:51

k8s-ci-robot assigned ahg-g Jan 21, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026

k8s-ci-robot merged commit bfd5fc7 into kubernetes-sigs:main Jan 21, 2026
11 checks passed

Conversation

capri-xiyue commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 20, 2026

Uh oh!

netlify bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

capri-xiyue commented Jan 20, 2026

Uh oh!

capri-xiyue commented Jan 20, 2026

Uh oh!

ahg-g Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

kaushikmitr Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ahg-g Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

capri-xiyue Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahg-g commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capri-xiyue commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahg-g commented Jan 21, 2026

Uh oh!

capri-xiyue commented Jan 21, 2026

Uh oh!

ahg-g commented Jan 21, 2026

Uh oh!

k8s-ci-robot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

capri-xiyue commented Jan 20, 2026 •

edited

Loading

netlify bot commented Jan 20, 2026 •

edited

Loading

capri-xiyue Jan 21, 2026 •

edited

Loading

ahg-g commented Jan 21, 2026 •

edited

Loading

capri-xiyue commented Jan 21, 2026 •

edited

Loading