-
Notifications
You must be signed in to change notification settings - Fork 277
test: added latency predictor converage for inferencepool and added convera… #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
d42f2fd
f45b208
4cf13ac
ac0e7cb
6571281
b4207d5
b2ba12a
974aa3b
b7c0e8a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -296,3 +296,94 @@ inferenceExtension: | |
|
|
||
| latencyPredictor: | ||
| enabled: false | ||
|
|
||
| # Training Server Configuration | ||
| trainingServer: | ||
| image: | ||
| hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars | ||
|
||
| name: latencypredictor-training-server | ||
| tag: latest | ||
| pullPolicy: Always | ||
| port: 8000 | ||
| resources: | ||
| requests: | ||
| cpu: "2000m" | ||
| memory: "4Gi" | ||
| limits: | ||
| cpu: "4000m" | ||
| memory: "8Gi" | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| port: 8000 | ||
| initialDelaySeconds: 30 | ||
| periodSeconds: 20 | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /readyz | ||
| port: 8000 | ||
| initialDelaySeconds: 45 | ||
| periodSeconds: 10 | ||
| volumeSize: "20Gi" | ||
| config: | ||
| LATENCY_RETRAINING_INTERVAL_SEC: "1" | ||
| LATENCY_MIN_SAMPLES_FOR_RETRAIN: "100" | ||
| LATENCY_TTFT_MODEL_PATH: "/models/ttft.joblib" | ||
| LATENCY_TPOT_MODEL_PATH: "/models/tpot.joblib" | ||
| LATENCY_TTFT_SCALER_PATH: "/models/ttft_scaler.joblib" | ||
| LATENCY_TPOT_SCALER_PATH: "/models/tpot_scaler.joblib" | ||
| LATENCY_MODEL_TYPE: "xgboost" | ||
| LATENCY_MAX_TRAINING_DATA_SIZE_PER_BUCKET: "5000" | ||
| LATENCY_QUANTILE_ALPHA: "0.9" | ||
|
|
||
| # Prediction Server Configuration | ||
| predictionServers: | ||
| count: 10 | ||
| startPort: 8001 | ||
| image: | ||
| hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars | ||
| name: latencypredictor-prediction-server | ||
| tag: latest | ||
| pullPolicy: Always | ||
| resources: | ||
| requests: | ||
| cpu: "500m" | ||
| memory: "1Gi" | ||
| limits: | ||
| cpu: "1000m" | ||
| memory: "2Gi" | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| initialDelaySeconds: 15 | ||
| periodSeconds: 15 | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /readyz | ||
| initialDelaySeconds: 10 | ||
| periodSeconds: 5 | ||
| failureThreshold: 10 | ||
| volumeSize: "10Gi" | ||
| config: | ||
| LATENCY_MODEL_TYPE: "xgboost" | ||
| PREDICT_HOST: "0.0.0.0" | ||
| LOCAL_TTFT_MODEL_PATH: "/server_models/ttft.joblib" | ||
| LOCAL_TPOT_MODEL_PATH: "/server_models/tpot.joblib" | ||
| LOCAL_TTFT_SCALER_PATH: "/server_models/ttft_scaler.joblib" | ||
| LOCAL_TPOT_SCALER_PATH: "/server_models/tpot_scaler.joblib" | ||
|
|
||
| # EPP Environment Variables for Latency Predictor | ||
| eppEnv: | ||
| LATENCY_MAX_SAMPLE_SIZE: "10000" | ||
|
|
||
|
|
||
| # Options: ["gke"] | ||
| provider: | ||
| name: none | ||
|
|
||
| # GKE-specific configuration. | ||
| # This block is only used if name is "gke". | ||
| gke: | ||
| # Set to true if the cluster is an Autopilot cluster. | ||
| autopilot: false | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| {{- define "inference-extension.gke" -}} | ||
| {{- if eq (lower .Values.provider.name) "gke" }} | ||
| {{- if and .Values.provider (eq (lower .Values.provider.name) "gke") }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was this a bug?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Previously in inferencepool helm chart, as the values.yaml provides a none as a default, we won't have issues. But in epp-standalone helm chart, the default "none" was not provided. Therefore, it will encounter issue. I've made default "none" in this PR and here check provider exists before before accessing the value(more defensive). I was testing "gke" set up, therefore didn't notice this when there was no provider value. |
||
| {{- if and .Values.inferenceExtension.monitoring.prometheus.enabled .Values.inferenceExtension.monitoring.prometheus.auth.enabled }} | ||
| {{- $metricsReadSA := printf "%s-metrics-reader-sa" .Release.Name -}} | ||
| {{- $metricsReadSecretName := printf "%s-metrics-reader-secret" .Release.Name -}} | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.