First part of refactoring the ExtProc used by both the EPP and the BBR by shmuelk · Pull Request #2428 · kubernetes-sigs/gateway-api-inference-extension

shmuelk · 2026-02-26T13:58:15Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Both the Endpoint Picker (EPP) and the Body Based Router (BBR) are Envoy ExtProc filters. There is much code that has been copy and pasted from one to the other.

This PR is the first in a series of PRs that will refactor out the common Ext Proc processing code into a set of reusable packages. This is being done to try and keep the PRs somewhat smaller.

In particular this PR:
1. Moves the basic header handling code to a common package
2. Moves the request id and default flow id constants to common packages
3. Updates other parts of the code base due to the above changes

Which issue(s) this PR fixes:
Fixes #2427
Ref: #2411

Does this PR introduce a user-facing change?:

NONE

netlify · 2026-02-26T13:58:22Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`21b697e`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69a53a42bd517e0008cd926d
😎 Deploy Preview	https://deploy-preview-2428--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

shmuelk · 2026-02-26T15:02:03Z

/test pull-gateway-api-inference-extension-verify-main

nirrozenbaum · 2026-03-01T20:51:28Z

+limitations under the License.
+*/
+
+package request


nit: what do you think about putting this under pkg/common/envoy/...?
the functions here are using envoy structs.

Done.

I moved most of the code under pkg/common/requests to pkg/common/envoy/requests. I left behind the definition of the header key, which isn't Envoy related.

nirrozenbaum

/lgtm
/approve

Thanks @shmuelk, looks great.
I left one nit about the package name, holding in case you want to handle.
not a blocker (you can unblock is you don't agree).

/hold

k8s-ci-robot · 2026-03-01T20:59:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, shmuelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shmuelk · 2026-03-02T07:08:04Z

/hold cancel

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

nirrozenbaum · 2026-03-02T08:46:03Z

Thanks!

/lgtm

kubernetes-sigs#2428) * Moved base header helpers to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * BBR to use requestIdKey from pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Moved default flow ID to pkg/metadata Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of requestId header key Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed copyright text Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Increased timeout, times out if Git is slow Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Reverted change to ready timeout Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Increased metrics curl timeout for slower systems Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updated new test with updated header key location Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Moved envoy related code under new common/envoy package Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Changes due to package refactoring Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Changes due to package refactoring Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

kubernetes-sigs/gateway-api-inference-extension#2428) * Moved base header helpers to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * BBR to use requestIdKey from pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Moved default flow ID to pkg/metadata Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of requestId header key Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed copyright text Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Increased timeout, times out if Git is slow Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Reverted change to ready timeout Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Increased metrics curl timeout for slower systems Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updated new test with updated header key location Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Moved envoy related code under new common/envoy package Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Changes due to package refactoring Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Changes due to package refactoring Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 26, 2026

k8s-ci-robot requested review from kfswain and nirrozenbaum February 26, 2026 13:58

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2026

shmuelk force-pushed the ext-proc-refactor-1 branch from b490418 to 50215fb Compare March 1, 2026 10:17

nirrozenbaum reviewed Mar 1, 2026

View reviewed changes

Comment thread pkg/common/request/headers.go Outdated

nirrozenbaum approved these changes Mar 1, 2026

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2026

k8s-ci-robot assigned nirrozenbaum Mar 1, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2026

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 1, 2026

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2026

shmuelk added 11 commits March 2, 2026 09:14

Moved base header helpers to pkg/common

3ca7589

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

BBR to use requestIdKey from pkg/common

6a626b7

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Moved default flow ID to pkg/metadata

522c1dc

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Updates due to move of requestId header key

a9a677e

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Fixed copyright text

d4bbf41

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Increased timeout, times out if Git is slow

2089c92

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Reverted change to ready timeout

7e684bc

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Increased metrics curl timeout for slower systems

9dca37b

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Updated new test with updated header key location

a7cab2a

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Moved envoy related code under new common/envoy package

2f47ba6

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Changes due to package refactoring

4b25c46

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

shmuelk force-pushed the ext-proc-refactor-1 branch from 69795ff to 4b25c46 Compare March 2, 2026 07:14

Changes due to package refactoring

21b697e

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2026

k8s-ci-robot merged commit 4c6c187 into kubernetes-sigs:main Mar 2, 2026
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First part of refactoring the ExtProc used by both the EPP and the BBR#2428

First part of refactoring the ExtProc used by both the EPP and the BBR#2428
k8s-ci-robot merged 12 commits intokubernetes-sigs:mainfrom
shmuelk:ext-proc-refactor-1

shmuelk commented Feb 26, 2026

Uh oh!

netlify Bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

shmuelk commented Feb 26, 2026

Uh oh!

nirrozenbaum Mar 1, 2026

Uh oh!

shmuelk Mar 2, 2026

Uh oh!

Uh oh!

nirrozenbaum left a comment

Uh oh!

k8s-ci-robot commented Mar 1, 2026

Uh oh!

shmuelk commented Mar 2, 2026

Uh oh!

nirrozenbaum commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shmuelk commented Feb 26, 2026

Uh oh!

netlify Bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

shmuelk commented Feb 26, 2026

Uh oh!

nirrozenbaum Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

shmuelk Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nirrozenbaum left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 1, 2026

Uh oh!

shmuelk commented Mar 2, 2026

Uh oh!

nirrozenbaum commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Feb 26, 2026 •

edited

Loading