Skip to content

Initial drop of remote test-e2e-node equivalent for AWS#2

Merged
dims merged 2 commits into
masterfrom
initial-drop-of-remote-test-e2e-node-for-aws
Apr 7, 2023
Merged

Initial drop of remote test-e2e-node equivalent for AWS#2
dims merged 2 commits into
masterfrom
initial-drop-of-remote-test-e2e-node-for-aws

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Apr 7, 2023 •
edited
Loading

test-e2e-node as present in kubernetes/kubernetes repository only supports SSH and GCE currently.

This repository has code that was originally in the repos, PR(s), branches from @mahamed @tzneal and myself:

The vendor directory also has 2 changes not yet merged in k8s:

⚠️ ⚠️ ⚠️ ⚠️ ⚠️
Please make sure the default security group rules allow SSH (port 22) access.
⚠️ ⚠️ ⚠️ ⚠️ ⚠️

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 7, 2023

/assign @upodroid @tzneal

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2023

@dims: GitHub didn't allow me to assign the following users: tzneal.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @upodroid @tzneal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 7, 2023
Davanum Srinivas and others added 2 commits April 7, 2023 16:31
@upodroid @tzneal
Initial drop of remote test-e2e-node equivalent for AWS
37c6b8c 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Co-Authored-By: upodroid <cy@borg.dev>
Co-Authored-By: Todd Neal <tnealt@amazon.com>
vendor
eef751e
@dims dims force-pushed the initial-drop-of-remote-test-e2e-node-for-aws branch from b16bb82 to eef751e Compare April 7, 2023 16:32
@dims dims mentioned this pull request Apr 7, 2023
Closed
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 7, 2023

Please see the output from the full run here:
https://pastebin.ubuntu.com/p/V6wrGB6xHC/plain/

@dims dims merged commit 17f4e43 into master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nckturner nckturner Awaiting requested review from nckturner

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@upodroid upodroid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dims @k8s-ci-robot @upodroid