Specify kube root for test-e2e-node/aws to work#117141
Merged
k8s-ci-robot merged 1 commit intoApr 12, 2023
Merged
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 6 14:00:15 UTC 2023. |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
dims
force-pushed
the
specify-kube-root-for-test-e2e-node/AWS
branch
from
fbbd4f5 to
d6d4be8
Compare
k8s-ci-robot
added
size/M
test-e2e-node for AWS is out-of-tree so that we won't need to vendor in AWS related packages. For this to work, some of the scripts/golang code need to know where the k8s tree is git cloned. So let's add an option to lookup the env var, so that we can then, change directory to this specified directory to run some make commands Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
specify-kube-root-for-test-e2e-node/AWS
branch
from
d6d4be8 to
d3ae6c2
Compare
k8s-ci-robot
added
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dims
changed the title
k8s-ci-robot
added
release-note-none
Member
Author
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
Member
Author
|
/assign @SergeyKanzhelev @tzneal |
Contributor
|
/retest |
Contributor
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: c818678df604ae4e8656a655c5bb7eacdf874f3e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test-e2e-node for AWS is out-of-tree so that we won't need to vendor
in AWS related packages. For this to work, some of the scripts/golang
code need to know where the k8s tree is git cloned.
So let's add an option to lookup the env var, so that we can then,
change directory to this specified directory to run some make commands
Signed-off-by: Davanum Srinivas davanum@gmail.com
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: