Skip to content

Feat: graduate kube-scheduler component config to GA #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2022
Merged

Feat: graduate kube-scheduler component config to GA #3346

merged 2 commits into from
Jun 14, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Jun 7, 2022

Signed-off-by: kerthcet [email protected]

  • One-line PR description: graduate kube-scheduler component config to GA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g June 7, 2022 02:54
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 7, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Jun 7, 2022

/sig scheduling
cc @wojtek-t @alculquicondor

alculquicondor
alculquicondor reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t, note that this is a follow up to #3315 which merged early due to my mistake

@wojtek-t wojtek-t self-assigned this Jun 7, 2022
wojtek-t
wojtek-t reviewed Jun 7, 2022
View reviewed changes
keps/sig-scheduling/785-scheduler-component-config-api/README.md
@@ -228,6 +228,12 @@ N/A
When `v1` gets introduced:
- Mark `v1beta2` as deprecated.

* **Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look tomorrow.

In the meantime - please also adopt to new format of Test Plan:
https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md#test-plan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the new test plan, PTAL

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2022
@kerthcet kerthcet mentioned this pull request Jun 14, 2022
Merged
@kerthcet
add test plans
38c3dc4 
Signed-off-by: kerthcet <[email protected]>
@kerthcet kerthcet force-pushed the feature/ga-conponent-config branch from 7c0665e to 38c3dc4 Compare June 14, 2022 03:58
@kerthcet
Copy link
Member Author

kindly ping @wojtek-t

@wojtek-t
Copy link
Member

This looks fine.

/approve PRR

@alculquicondor - please add it to the tracking sheet:
https://docs.google.com/spreadsheets/d/1Lnft8598eIQsqBp8W6X_LwaqBNZViYssQoFgGS8aJ3g/edit?pli=1#gid=0

@alculquicondor
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 592363a into kubernetes:master Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@kerthcet kerthcet deleted the feature/ga-conponent-config branch June 14, 2022 14:18
@alculquicondor
Copy link
Member

Added to tracking sheet.

Note that this enhancement requires updating any samples that we have in the website to use the v1 API.

@kerthcet
Copy link
Member Author

Added to tracking sheet.

Note that this enhancement requires updating any samples that we have in the website to use the v1 API.

Thanks for reminding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@alculquicondor alculquicondor

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@kerthcet @wojtek-t @alculquicondor @k8s-ci-robot