Skip to content

KEP-4817: Add beta graduation criteria + implementation history #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2025
Merged

KEP-4817: Add beta graduation criteria + implementation history #5043

merged 2 commits into from
Feb 11, 2025

Conversation

LionelJouin
Copy link
Member

  • One-line PR description: Add beta graduation criteria + implementation history
  • Other comments: KEP-4817

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2025
aojea
aojea reviewed Jan 15, 2025
View reviewed changes
keps/sig-node/4817-resource-claim-device-status/README.md
Comment on lines +441 to +442
- The kubernetes-sigs/cni-dra-driver project as reference implementation for this feature.
- A new EndpointSlice Controller consuming the `ResourceClaim.Status.Devices[].NetworkData.Addresses` field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just it is important to mention that we need automated e2e test running periodically in beta, to take into consideration is not just to merge the code, is to make sure it is working and tested.
I'll be helping with that but I can not own it, I already maintain all the other testing ... so I expect the multi network community to own this CI , is that fair?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean automated e2e tests running periodically for the cni-dra-driver and this new EndpointSlice Controller? I think that is fair yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of testing: there's a test flake in the existing E2E (kubernetes/kubernetes#130096), please fix before the beta graduation.

@aojea
Copy link
Member

aojea commented Jan 20, 2025 •
edited
Loading

@LionelJouin you need to update the kep.yaml metadata , then it is LGTM

enhancements/keps/sig-node/4817-resource-claim-device-status/kep.yaml

Lines 29 to 36 in 0468644

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha #beta|stable
latest-milestone: "v1.32"
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.32"

/assign @johnbelamaric for PRR review

@LionelJouin
Copy link
Member Author

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Feb 4, 2025
johnbelamaric
johnbelamaric reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, including PRR

keps/sig-node/4817-resource-claim-device-status/kep.yaml Outdated
@@ -27,7 +27,7 @@ see-also:
- "https://github.com/k8snetworkplumbingwg/network-attachment-definition-client"

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha #beta|stable
stage: beta

latest-milestone: "v1.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.33, and add in the milestone below too

@pohly pohly mentioned this pull request Feb 11, 2025
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
johnbelamaric
johnbelamaric reviewed Feb 11, 2025
View reviewed changes
keps/sig-node/4817-resource-claim-device-status/kep.yaml Outdated

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.32"
alpha: "v1.33"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still be alpha for 1.32, and add a beta field for 1.33

@LionelJouin
[KEP-4817] Set stage to beta
e3ba210 
Signed-off-by: Lionel Jouin <[email protected]>
@johnbelamaric
Copy link
Member

/assign @mrunalp

PRR is good to go, needs SIG approval

@johnbelamaric
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, LionelJouin, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5d0fa9d into kubernetes:master Feb 11, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@aojea aojea aojea left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@mrunalp mrunalp

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: ✅ Done
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
6 participants
@LionelJouin @aojea @johnbelamaric @k8s-ci-robot @pohly @mrunalp