Skip to content

KEP-4817: Add beta graduation criteria + implementation history #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

KEP-4817: Add beta graduation criteria + implementation history #5043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c4d08
[KEP-4817] Add beta graduation criteria + implementation history
LionelJouin Jan 15, 2025
e3ba210
[KEP-4817] Set stage to beta
LionelJouin Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-node/4817.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
kep-number: 4817
alpha:
approver: "@johnbelamaric"
beta:
approver: "@johnbelamaric"
4 changes: 4 additions & 0 deletions keps/sig-node/4817-resource-claim-device-status/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,8 @@ network status.
- Feature Gates are enabled by default.
- No major outstanding bugs.
- 1 example of real-world usage.
- The kubernetes-sigs/cni-dra-driver project as reference implementation for this feature.
- A new EndpointSlice Controller consuming the `ResourceClaim.Status.Devices[].NetworkData.Addresses` field.
Comment on lines +441 to +442
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just it is important to mention that we need automated e2e test running periodically in beta, to take into consideration is not just to merge the code, is to make sure it is working and tested.
I'll be helping with that but I can not own it, I already maintain all the other testing ... so I expect the multi network community to own this CI , is that fair?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean automated e2e tests running periodically for the cni-dra-driver and this new EndpointSlice Controller? I think that is fair yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of testing: there's a test flake in the existing E2E (kubernetes/kubernetes#130096), please fix before the beta graduation.

- Feedback collected from the community (developers and users) with adjustments
provided, implemented and tested.

Expand Down Expand Up @@ -611,6 +613,8 @@ N/A
## Implementation History

- Initial proposal: 2024-08-30
- Implementation merged ([kubernetes/kubernetes#128240](https://github.com/kubernetes/kubernetes/pull/128240)): 2024-11-08
- Released as an alpha feature behind a feature-gate: 2024-12-11 (Kubernetes v1.32)

## Drawbacks

Expand Down
5 changes: 3 additions & 2 deletions keps/sig-node/4817-resource-claim-device-status/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ see-also:
- "https://github.com/k8snetworkplumbingwg/network-attachment-definition-client"

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha #beta|stable
stage: beta

latest-milestone: "v1.32"
latest-milestone: "v1.33"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.32"
beta: "v1.33"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down