-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Controller: Several security fixes. #13070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e0dc78b
to
dc07fc8
Compare
/triage accepted |
New changes are detected. LGTM label has been removed. |
60d09aa
to
7234a62
Compare
Sorry if this is ignorant - but will this fix be backported to controller-1.10? |
This is not arrogant, no worries. v1.10 has been discontinued with the release of v1.12. We normally only maintain Since v1.10 already go discontinued some time ago, we cannot release a v1.10.7, even if we wanted, because it's not only missing the relevant security fixes, but also tons of other back-ported changes like dependency updates or code maintenance. |
Directly disabed |
Separating the Controller and Nginx components into different pods should resolve this issue. Decoupling the Controller and Nginx into separate pods can also fix other problems that may arise from having them co-located in the same pod. It seems like this was mentioned in 2024 roadmap. I'm not sure if it's still in the plans at the moment. |
Fixes: