Fix #198 - make GIT's safe.directory '*' by default on repository fetch
#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fetch This is an ugly side-effect, and it will modify the environment of users that rely on this package outside the context of the delivered docker container, but it is a good workaround for the security and compatibility mess that GIT 2.35.3 introduced. In fact, this application was never meant to run in multi-user mode, and the container it runs will not be affected by side effects (mostly git hooks) in freshly checked out code. Ref: https://stackoverflow.com/a/71904131/347063 Ref: https://git-scm.com/docs/git-config/2.35.2#Documentation/git-config.txt-safedirectory Ref: https://marc.info/?l=git&m=164989570902912&w=2 Ref: git/git@8959555 Ref: git-for-windows/git#3809 (comment)
Ocramius
commented
Jul 26, 2022
boesing
approved these changes
Jul 26, 2022
|
🚢 Trying out a release ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly side-effect, and it will modify the environment of users that rely on this package
outside the context of the delivered docker container, but it is a good workaround for the security
and compatibility mess that GIT 2.35.3 introduced.
In fact, this application was never meant to run in multi-user mode, and the container it runs will
not be affected by side effects (mostly git hooks) in freshly checked out code.
Ref: https://stackoverflow.com/a/71904131/347063
Ref: https://git-scm.com/docs/git-config/2.35.2#Documentation/git-config.txt-safedirectory
Ref: https://marc.info/?l=git&m=164989570902912&w=2
Ref: git/git@8959555
Ref: git-for-windows/git#3809 (comment)