Skip to content

Merge release 1.14.0 into 1.15.x #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2022

Conversation

github-actions[bot]
Copy link

Release Notes for 1.14.0

Feature release (minor)

1.14.0

  • Total issues resolved: 2
  • Total pull requests resolved: 17
  • Total contributors: 5

Bug

renovate

dependencies

Enhancement

Enhancement,dependencies

laminas-bot and others added 8 commits July 25, 2022 22:32
Updates the CHANGELOG.md file to add a changelog entry for a new 1.14.1 version.
…ush`

This should fix some underlying design issues described in #198

The full URI of the repository, which includes a token in plaintext, is now no
longer the actual `git remote` URI, and is instead stored in a temporary
file which `git` uses to authenticate with the remote.

This prevents the remote URI from leaking in `STDOUT`/`STDERR`, which are
visible in case of crashes.
…xfiltate those credentials

This test fails on `1.14.x`, and succeeds on `HEAD`, therefore validating the current patch, and
preventing a security regression.
…tial-store-for-authentication

Use `git config credential.helper 'store --file=/tmp/file' for `git push`
… fetch

This is an ugly side-effect, and it will modify the environment of users that rely on this package
outside the context of the delivered docker container, but it is a good workaround for the security
and compatibility mess that GIT 2.35.3 introduced.

In fact, this application was never meant to run in multi-user mode, and the container it runs will
not be affected by side effects (mostly git hooks) in freshly checked out code.

Ref: https://stackoverflow.com/a/71904131/347063
Ref: https://git-scm.com/docs/git-config/2.35.2#Documentation/git-config.txt-safedirectory
Ref: https://marc.info/?l=git&m=164989570902912&w=2
Ref: git/git@8959555
Ref: git-for-windows/git#3809 (comment)
…-any-directory

Fix #198 - make GIT's `safe.directory` `'*'` by default on repository fetch
Updates the CHANGELOG.md to set the release date.
@Ocramius Ocramius self-assigned this Jul 26, 2022
@Ocramius Ocramius added the Bug Something isn't working label Jul 26, 2022
@Ocramius Ocramius added this to the 1.15.0 milestone Jul 26, 2022
@Ocramius
Copy link
Member

'bit of a strange one: 1.14.0 was re-tagged due to a really bad security problem, so this patch fixes that.

@Ocramius Ocramius merged commit ffe777e into 1.15.x Jul 26, 2022
@Ocramius Ocramius deleted the 1.14.x-merge-up-into-1.15.x_qaCj71FU branch July 26, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants