Skip to content
This repository was archived by the owner on Jun 6, 2021. It is now read-only.

Merge release 1.0.1 into 1.1.x #4

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

github-actions[bot]
Copy link

Release Notes for 1.0.1

1.0.x bugfix release (patch)

1.0.1

@boesing
Copy link
Member

boesing commented Apr 7, 2021

Due to circular dependencies, the build does not work anymore.
The problem is, that we still used ^2.10@dev in #5 and thus, 2.10.0-rc1 was used by composer.

I am thinking of creating a GHA to set COMPOSER_ROOT_VERSION to <target branch where x is replaced with 99>. This should fix the circular dependency issue properly.

@Slamdunk
Copy link
Contributor

Slamdunk commented Apr 7, 2021

Maybe a pre-command could suffice: https://github.com/laminas/laminas-continuous-integration-action/#prepost-commands

@boesing boesing force-pushed the 1.0.x-merge-up-into-1.1.x_5f847e83940230.80140719 branch 4 times, most recently from 3600738 to a446481 Compare April 7, 2021 16:13
@boesing boesing merged commit 34b8abc into 1.1.x Apr 7, 2021
@boesing
Copy link
Member

boesing commented Apr 7, 2021

@Slamdunk I've created laminas/laminas-continuous-integration-action#19 for pre-install.sh script and moved the change to #7 to keep the merge-up clean.

@boesing boesing deleted the 1.0.x-merge-up-into-1.1.x_5f847e83940230.80140719 branch April 7, 2021 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants