feat: add pre-install script execution
#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
feature/pre-install-script
branch
2 times, most recently
from
adbd233 to
de75b9b
Compare
weierophinney
requested changes
Apr 7, 2021
boesing
force-pushed
the
feature/pre-install-script
branch
from
de75b9b to
40f2f2d
Compare
weierophinney
requested changes
Apr 7, 2021
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
feature/pre-install-script
branch
from
40f2f2d to
d57c5cc
Compare
weierophinney
approved these changes
Apr 7, 2021
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
laminas-cache, we have use-cases where we either want to manually compile PHP extensions withpeclto suit composer requirements or extending the ENV forcomposerto avoid circular dependency issues.The current
pre-run.shis being executed aftercomposer installis being executed and thus, it will fail before we reach the script.In order to solve that issue, I'd like to introduce a
pre-install.shscript, which is being executed in an earlier stage of the process.