Skip to content

bugfix: checkout the source before interacting with it #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

boesing
Copy link
Member

@boesing boesing commented Apr 7, 2021

Q A
Bugfix yes

Description

With #19, the .laminas-ci/pre-install.sh script was introduced.
I totally missed, that the checkout of the repository takes place later in the process.

This fix moves the checkout right after the PHP version handling and right before the check for the pre-install.sh script.

@boesing boesing added the Bug Something isn't working label Apr 7, 2021
@boesing boesing added this to the 1.5.1 milestone Apr 7, 2021
@boesing boesing requested a review from weierophinney April 7, 2021 21:20
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof... missed that when I reviewed #19!

@weierophinney weierophinney changed the base branch from 1.6.x to 1.5.x April 7, 2021 21:24
@weierophinney weierophinney merged commit eee0134 into laminas:1.5.x Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants