Update required node version to match the one installed #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Lockett <[email protected]>
|
The target/lib version of ECMAscript to use was taken from: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping. Node v18 will probably support |
|
Well, post-merge build is red 😩 |
|
Nvm, seems like a |
|
Odd that it was green in the PR. I suspect you're correct, but https://github.com/laminas/laminas-ci-matrix-action/tree/1.14.x/tests/code-check-deprecated-exclusion-via-config is the failing test on both release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dockerfile installed node v18, however package.json is using node v17. This PR updates the latter to ensure there is no confusion by developers or by the tools.
There are also a couple of removal instances of unused lines of code, which I can undo if requested. In this vein, I also added double quoting inside the shell scripts to prevent globbing and word splitting.