Diff variable needs to be unquoted when passed to the application

[internalsystemerror]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

Sometimes when running the action on a pull request, it's unable to correctly perform the regex checks on the list of filenames and incorrectly returns no checks to be performed (see https://github.com/laminas/laminas-filter/actions/runs/3732216426/jobs/6332977468).

This appears to have been introduced by #117 and after various discussion over slack and with @Xerkus help, it is believed that this PR should fix that issue.

[weierophinney]

That is sooooo odd; normal rule of thumb is to ALWAYS quote arguments in shell scripts. Would love to know why this occurs...

[internalsystemerror]

Same. I think the list of files gets read as a single string, but I'm not certain. It should be easy enough to see what's happening around

laminas-ci-matrix-action/src/main.ts

Lines 14 to 22 in 5e50256

	/**
	* Remove the first two arguments from this process.
	* - first index contains the binary which is used to execute JS (nodejs)
	* - second argument contains the filename which is being executed
	* After the first two arguments, all remaining arguments should contain filenames from a `diff`. Can be empty in case
	* the action is not run from a pull-request.
	*/
	/* eslint-disable-next-line no-magic-numbers */
	const filesWithChanges: string[] = process.argv.slice(2).filter((value) => value !== '');

though.

[Xerkus]

Each file name from diff is expected to be a separate argument and it explicitly relies on shell word splitting behavior using IFS.
Double quoting prevented word splitting and the whole diff ended up passed as a single argument which then failed to match non-multiline regex like \.php$ as it would effectively be matching only the very last file