[12.x] Syntax highlight on the frontend #57184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avosalmon
commented
Sep 26, 2025
Comment on lines
11
to
37
| $fallback = $truncate ? '<pre class="truncate"><code>' : '<pre><code>'; | ||
| $lines = explode("\n", $code); | ||
| if ($highlightedLine !== null) { | ||
| $highlightedCode->decoration( | ||
| LineDecoration::forLine($highlightedLine)->class('bg-rose-200! [&_.line-number]:dark:text-white! dark:bg-rose-900!'), | ||
| ); | ||
| if ($editor) { | ||
| foreach ($lines as $index => $line) { | ||
| $lineNumber = $startingLine + $index; | ||
| $highlight = $highlightedLine === $index; | ||
| $lineClass = implode(' ', [ | ||
| 'block px-4 py-1 h-7 even:bg-white odd:bg-white/2 even:dark:bg-white/2 odd:dark:bg-white/4', | ||
| $highlight ? 'bg-rose-200! dark:bg-rose-900!' : '', | ||
| ]); | ||
| $lineNumberClass = implode(' ', [ | ||
| 'mr-6 text-neutral-500! dark:text-neutral-600!', | ||
| $highlight ? 'dark:text-white!' : '', | ||
| ]); | ||
| $fallback .= '<span class="' . $lineClass . '">'; | ||
| $fallback .= '<span class="' . $lineNumberClass . '">' . $lineNumber . '</span>'; | ||
| $fallback .= htmlspecialchars($line); | ||
| $fallback .= '</span>'; | ||
| } | ||
| } else { | ||
| $fallback .= htmlspecialchars($code); | ||
| } | ||
| $fallback .= '</code></pre>'; |
Contributor
Author
There was a problem hiding this comment.
When JavaScript is disabled, the fallback will be rendered without syntax highlighting.
NickSdot
pushed a commit
to NickSdot/laravel-framework
that referenced
this pull request
Oct 30, 2025
* Remove phiki * Install shiki * Update Node version * Use shiki to highlight code * Adjust editor styling * Render line numbers * Highlight code on init * Tweak frame border style * Hide vendor frames until Alpine is loaded * Apply fixes from StyleCI * Format --------- Co-authored-by: StyleCI Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new local exception page introduced the
phiki/phikicomposer package for syntax highlighting.This significantly increased the application size (by ~13 MB), causing issues with Vapor deployments. #57117
This PR removes the
phiki/phikipackage and replaces it with shiki to handle syntax highlighting on the frontend.With Fine-grained Bundle, the JavaScript bundle only includes the necessary languages (PHP, SQL, and JSON) and themes (Light Plus and Dark Plus).
The increase in the JavaScript bundle size is approximately 600KB.