[3.x] Fix memory leak and potential caching issue with usePage#1366
Merged
taylorotwell merged 1 commit into3.xfrom Aug 23, 2023
Merged
[3.x] Fix memory leak and potential caching issue with usePage#1366taylorotwell merged 1 commit into3.xfrom
taylorotwell merged 1 commit into3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak and potential caching issue in the Vue stack when calling
usePageinside a computed prop or watcher.usePageshould be called at the top level of<script setup>per the example in the docs at https://inertiajs.com/shared-data#accessing-shared-data.See inertiajs/inertia#1602 (comment) for more information.