Skip to content

[3.x] Fix memory leak and potential caching issue with usePage #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 1 commit into from
Aug 23, 2023
Merged

[3.x] Fix memory leak and potential caching issue with usePage #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions stubs/inertia/resources/js/Components/Banner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
<script setup>
import {ref, watchEffect} from 'vue';
import { ref, watchEffect } from 'vue';
import { usePage } from '@inertiajs/vue3';

const page = usePage();
const show = ref(true);
const style = ref('success');
const message = ref('');

watchEffect(async () => {
style.value = usePage().props.jetstream.flash?.bannerStyle || 'success';
message.value = usePage().props.jetstream.flash?.banner || '';
style.value = page.props.jetstream.flash?.bannerStyle || 'success';
message.value = page.props.jetstream.flash?.banner || '';
show.value = true;
});
</script>
Expand Down
3 changes: 2 additions & 1 deletion stubs/inertia/resources/js/Pages/Profile/Partials/TwoFactorAuthenticationForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const props = defineProps({
requiresConfirmation: Boolean,
});

const page = usePage();
const enabling = ref(false);
const confirming = ref(false);
const disabling = ref(false);
Expand All @@ -26,7 +27,7 @@ const confirmationForm = useForm({
});

const twoFactorEnabled = computed(
() => ! enabling.value && usePage().props.auth.user?.two_factor_enabled,
() => ! enabling.value && page.props.auth.user?.two_factor_enabled,
);

watch(twoFactorEnabled, () => {
Expand Down
4 changes: 3 additions & 1 deletion stubs/inertia/resources/js/Pages/Teams/Partials/TeamMemberManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ const props = defineProps({
userPermissions: Object,
});

const page = usePage();

const addTeamMemberForm = useForm({
email: '',
role: null,
Expand Down Expand Up @@ -69,7 +71,7 @@ const confirmLeavingTeam = () => {
};

const leaveTeam = () => {
leaveTeamForm.delete(route('team-members.destroy', [props.team, usePage().props.auth.user]));
leaveTeamForm.delete(route('team-members.destroy', [props.team, page.props.auth.user]));
};

const confirmTeamMemberRemoval = (teamMember) => {
Expand Down