Add EN+ Caro #1519
Add EN+ Caro #1519
Conversation
WalkthroughThe update adds a new section to the supported devices documentation for the EN+ Caro Series Home Wallbox. The section details configuration steps for integrating the charger with Home Assistant, including connecting to the charger’s access point, configuring network settings, using the charger’s serial number as the Charge point identity, and managing sensor settings due to firmware limitations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Wallbox as EN+ Caro Wallbox
participant HA as Home Assistant
participant OCPP as OCPP Server
User->>Wallbox: Connect to access point & obtain serial number
User->>HA: Enter configuration details (serial, network settings)
HA->>Wallbox: Send connection parameters & setup command
Wallbox->>OCPP: Establish connection with server
OCPP-->>Wallbox: Confirm OCPP connection
Wallbox-->>HA: Report enabled measurands & sensor status
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/supported-devices.md (5)
56-57: New Section Header for EN+ Caro Series Home Wallbox
The new section header and introductory note regarding the serial number are clear and informative. However, note that markdownlint suggests a setext style for certain headings (MD003). Please verify if using atx (i.e.##) here is consistent with the project’s overall markdown style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Heading style
Expected: setext; Actual: atx(MD003, heading-style)
58-61: Typographical Corrections in Connection Instructions
- On line 58, "accesss point" is misspelled and should be corrected to "access point."
- On line 61, "protocal" should be corrected to "protocol."
Additionally, ensure consistent use of apostrophes (e.g. “charger’s”) throughout this section.🧰 Tools
🪛 LanguageTool
[uncategorized] ~59-~59: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...(AP) by powering down the charger (i.e. switch off the charger's isolator or circuit b...(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
[uncategorized] ~59-~59: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...or 15 minutes, and the SSID matches the chargers serial number (starting with SN). Log ...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
64-64: Grammar Improvement in Connection Confirmation Step
The sentence on line 64 reads:"This confirms that charger has an internet connection via Ethernet or WiFi..."
Including the definite article improves readability. Please change it to:
"This confirms that the charger has an internet connection via Ethernet or WiFi..."
66-70: List Indentation Consistency for Key Measurands
The bullet list items (lines 66–70) are indented by three spaces. For consistency with the project’s markdown style guidelines (MD007), consider unindenting these list items so that they align with top-level bullet formatting.
71-71: Punctuation Enhancement in Firmware Note
In the sentence on line 71, consider adding a comma after "completed a charging session" for improved readability. For example:"You may wish to disable sensors that show Unknown after you've completed a charging session, as they will never provide data with the current firmware 1.4.859."
🧰 Tools
🪛 LanguageTool
[uncategorized] ~71-~71: You might be missing the article “the” here.
Context: ...k Status is online. This confirms that charger has an internet connection via Ethernet...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~71-~71: You might be missing the article “the” here.
Context: ...erver in Home Assistant. Once enabled, charger doesn't connect to the vendor server an...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/supported-devices.md
[uncategorized] ~59-~59: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...(AP) by powering down the charger (i.e. switch off the charger's isolator or circuit b...
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
[uncategorized] ~59-~59: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...or 15 minutes, and the SSID matches the chargers serial number (starting with SN). Log ...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[misspelling] ~63-~63: This word is normally spelled with a hyphen.
Context: ...ace are provided in the charger manual (case sensitive). Configure the network mode to WiFi o...
(EN_COMPOUNDS_CASE_SENSITIVE)
[uncategorized] ~71-~71: You might be missing the article “the” here.
Context: ...k Status is online. This confirms that charger has an internet connection via Ethernet...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~71-~71: You might be missing the article “the” here.
Context: ...erver in Home Assistant. Once enabled, charger doesn't connect to the vendor server an...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~80-~80: Possible missing comma found.
Context: ...known after you've completed a charging session as they will never provide data with th...
(AI_HYDRA_LEO_MISSING_COMMA)
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
56-56: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
74-74: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
75-75: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
76-76: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
coderabbitai suggested changes.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
docs/supported-devices.md (8)
56-56: Consistency in Heading Style
The new section’s heading is written in atx style (##) while earlier headings in this document use a different style. For consistency with the existing documentation, please consider adjusting the heading style if needed.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Heading style
Expected: setext; Actual: atx(MD003, heading-style)
57-57: Clarify the Charge Point Identity Note
The note on the charger's serial number is clear; however, rephrasing it slightly could improve clarity. For example, consider: "Note the charger’s serial number. You must use this number as theCharge point identitywhen configuring the OCPP integration in Home Assistant."
59-59: Refine Verb Tense for Access Point Availability
The phrase "becomes available for 15 minutes" might be improved for clarity—consider "remains available for 15 minutes" or "is available for 15 minutes" to better indicate the duration.🧰 Tools
🪛 LanguageTool
[uncategorized] ~59-~59: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...(AP) by powering down the charger (i.e. switch off the charger's isolator or circuit b...(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
60-60: Enhance Mobile Configuration Instructions
For users configuring via a phone, consider rephrasing to: "If using a phone, you might need to enable Flight Mode and then manually enable WiFi to ensure the configuration process completes successfully."
61-61: Correct Compound Adjective Hyphenation
The text "case sensitive" should be hyphenated to "case-sensitive" to correct the compound adjective usage.
62-62: Network Configuration Instruction Review
The instructions for configuring the network mode (WiFi or Ethernet) are clear. Optionally, you might include a brief troubleshooting tip if users face issues with connectivity.
73-79: Fix List Indentation in the Measurands Section
Markdown lint warnings indicate that unordered list items should not be indented. To resolve this, remove the extra indentation. For example, update as follows:-Even though the device accepts all measurands, the key working ones are - - `Current.Import` - - `Current.Offered` - - `Energy.Active.Import.Register` - - `Voltage` - - `Transaction.ID` +Even though the device accepts all measurands, the key working ones are: +- `Current.Import` +- `Current.Offered` +- `Energy.Active.Import.Register` +- `Voltage` +- `Transaction.ID`🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
74-74: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
75-75: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
76-76: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
80-80: Clarify Firmware Note on Sensor Readings
The note about disabling sensors that show as Unknown due to firmware limitations (version 1.4.859) is useful. Please verify that this firmware version is accurate and applicable across the board.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/supported-devices.md
[uncategorized] ~59-~59: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...(AP) by powering down the charger (i.e. switch off the charger's isolator or circuit b...
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
[misspelling] ~63-~63: This word is normally spelled with a hyphen.
Context: ...ace are provided in the charger manual (case sensitive). Configure the network mode to WiFi o...
(EN_COMPOUNDS_CASE_SENSITIVE)
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
56-56: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
74-74: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
75-75: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
76-76: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
🔇 Additional comments (3)
docs/supported-devices.md (3)
67-67: UI Behavior Confirmation
The statement that "The charger user interface will append the serial number when you leave the field" confirms expected behavior. This is clear and requires no changes.
69-69: Clear Reboot Instruction
"Save, and the charger will reboot." is concise and clear.
71-71: Reconnect and Verification Steps
The instructions for reconnecting to the charger's SSID and verifying that the network status is online are well-articulated.
Added note that voltage appears to be a figure captured once, rather than reported as it fluctuates:
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/supported-devices.md (5)
56-56: Review Heading Style Consistency
The new header for the EN+ Caro Series Home Wallbox is added using an ATX level-two heading (##). Please verify that this style aligns with our overall Markdown guidelines—in particular, whether subheadings in this file should follow the setext style used in the main title.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Heading style
Expected: setext; Actual: atx(MD003, heading-style)
58-58: Detailed Access Point Connection Procedure
The step-by-step guidance for connecting to the charger's access point is informative. Consider clarifying whether “a few seconds” is sufficient in all scenarios and confirming if the 15-minute availability is consistent across different firmware revisions.
59-59: Additional Guidance for Mobile Users
The instruction for phone users to set their device to Flight Mode is helpful. You might also mention that disabling mobile data could prevent unwanted network switching during configuration.
61-61: Network Configuration Details and Terminology
The instructions for setting the network mode and inputting the Home Assistant server address are clear. As a minor style note, some guidelines prefer “Wi‑Fi” (with a hyphen) over “WiFi.”
74-78: Bullet List Indentation Consistency
The list of key working measurands is indented by three spaces. To maintain consistency throughout the document, please consider using a uniform indentation (typically zero or one level) as per our Markdown style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
74-74: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
75-75: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
76-76: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/supported-devices.md
[misspelling] ~63-~63: This word is normally spelled with a hyphen.
Context: ...ace are provided in the charger manual (case sensitive). Configure the network mode to WiFi o...
(EN_COMPOUNDS_CASE_SENSITIVE)
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
56-56: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
74-74: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
75-75: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
76-76: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
🔇 Additional comments (6)
docs/supported-devices.md (6)
57-57: Clear Instruction on Charge Point Identity
The note instructing users to use the charger’s serial number as theCharge point identityis clear and provides necessary context about reconfiguring the integration if needed.
60-60: Credential Verification Notice
Stating that the username and password are provided in the charger manual is appropriate. It might be worth ensuring that the manual’s information is kept current, especially if firmware updates modify default credentials.
62-62: UI Behavior Confirmation
The explanation that the charger UI appends the serial number to the field—and that this is the expected behavior—provides good reassurance to the user.
63-63: Reboot Process Clarity
The directive “Save, and the charger will reboot” is succinct. It might be helpful to indicate if there’s any observable progress indicator or delay before the reboot occurs.🧰 Tools
🪛 LanguageTool
[misspelling] ~63-~63: This word is normally spelled with a hyphen.
Context: ...ace are provided in the charger manual (case sensitive). Configure the network mode to WiFi o...(EN_COMPOUNDS_CASE_SENSITIVE)
64-64: Post-Reboot Connection Check
The instructions for reconnecting to the charger's SSID to verify that the network status is online are comprehensive and practical for troubleshooting.
79-79: Firmware Limitation Advisory
The note regarding sensors that show “Unknown” due to firmware version 1.4.859 is a useful heads-up for troubleshooting. Ensure that this information is revisited if future firmware updates address this issue.
lbbrhzn
temporarily deployed
to
continuous-integration
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 12 12
Lines 2030 2030
=======================================
Hits 1883 1883
Misses 147 147 ☔ View full report in Codecov by Sentry. |
BJReplay
temporarily deployed
to
continuous-integration
GitHub Actions
Inactive
Closes #1517
Summary by CodeRabbit