-
-
Notifications
You must be signed in to change notification settings - Fork 101
Update supported-devices.md #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added other white-labelled varieties of the EN Plustech Caro charger. Added firmware update instructions and updated latest firmware version. Corrected information about `Voltage` measurand.
WalkthroughThe pull request updates the documentation for the EN+ Caro Series Home Wallbox charger. It expands details around the charger's compatibility—including white-labelling by Cord and EV Switch—and clarifies the firmware update and OCPP integration process in Home Assistant. The document now explains the necessity of using the charger’s serial number for both configuration and firmware update requests for versions earlier than 1.0.25.130, while also updating the measurand description for voltage and the referenced firmware version for sensor behavior. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as Charger
participant S as OCPP Server
participant E as Email System
U->>C: Check firmware version
alt Firmware < 1.0.25.130
U->>S: Connect to evchargo OCPP server
U->>E: Email serial number for firmware update
E->>C: Process firmware update request
else Firmware >= 1.0.25.130
U->>C: Access firmware update via configuration interface
end
Possibly related PRs
Suggested Reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 12 12
Lines 2050 2050
=======================================
Hits 1899 1899
Misses 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/supported-devices.md (1)
87-88
: Refined Measurand Description for Voltage & Markdown Style Suggestion
The updated description for theVoltage
measurand now correctly informs users that it shows a constant voltage or zero unless a charging session is in progress, thereby improving clarity. Additionally, the unordered list items on these lines have an indentation issue flagged by markdownlint (MD007). Consider adjusting the indentation (e.g., removing extra spaces) so that the list formatting is consistent with the rest of the document.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
87-87: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
88-88: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
87-87: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
88-88: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
🔇 Additional comments (2)
docs/supported-devices.md (2)
57-62
: Enhanced Charger Details: White Labelling and Firmware Update Instructions
The updated section now clarifies that the EN+ Caro Series Home Wallbox is often white-labelled by vendors like cord and EV Switch. In addition, it provides clear, step-by-step firmware update instructions for versions earlier than 1.0.25.130—specifying the use of the charger's serial number for both configuration and firmware-update requests. Please verify that all URLs, email addresses, and firmware version thresholds are current and accurate as per vendor guidelines.
90-90
: Guidance on Disabling Persistently Unknown Sensors
The newly added advisory instructs users to disable sensors that persistently displayUnknown
values after a charging session—an important note given the limitations of firmware 1.0.25.130. This improves user guidance and helps prevent confusion.
Added other white-labelled varieties of the EN Plustech Caro charger.
Added firmware update instructions and updated latest firmware version.
Corrected information about
Voltage
measurand.Summary by CodeRabbit