feat: multistream-select #297
Conversation
|
|
||
| [Multistream Select](https://github.com/multiformats/multistream-select) is | ||
| a protocol for friendly protocol multiplexing that allows for the negotiation | ||
| of a [multicodec](https://github.com/multiformats/multicodec) between two entities. |
There was a problem hiding this comment.
Is it a multicoded? It's just a string, isn't it?
| The header refers to the initial message sent by a peer to initiate the protocol | ||
| negotiation process. This message includes the protocol ID, `/multistream/1.0.0.`, | ||
| which indicates to the listening peer that a protocol negotiation process is about | ||
| to take place. Upon receiving this header, the listening peer responds with their | ||
| desired protocol header. |
There was a problem hiding this comment.
I wouldn't put too much emphasis on the header. It's not terribly important. Just say: Every multistream message is prefixed with a header, /multistream/1.0.0.
| protocol information and select the protocols to use for the connection, including | ||
| protocols for [security](../../secure-comm/overview.md) and | ||
| [stream multiplexing](../../multiplex/overview.md) if necessary. The | ||
| [protocol negotiation](../core-abstractions/connections#protocol-negotiation) | ||
| and [upgrade process](../core-abstractions/connections#upgrading-connections) | ||
| is explained further in the [connections document](../core-abstractions/connections.md). |
There was a problem hiding this comment.
This should be mentioned in the first paragraph:
libp2p uses multistream at various places:
- a
- b
- c
There was a problem hiding this comment.
It should still go after Multistream is introduced.
| as necessary. The [protocol negotiation](../core-abstractions/connections#protocol-negotiation) | ||
| and [upgrade process](../core-abstractions/connections#upgrading-connections) are explained | ||
| further in the [connections document](../core-abstractions/connections.md). | ||
|
|
There was a problem hiding this comment.
We should add a sentence saying that it's also used to select application protocols spoken on streams.
There was a problem hiding this comment.
👍 done with the last 3 commits.
Co-authored-by: Marten Seemann <[email protected]>
|
@p-shahi good to merge from my side. |
Context
Latest preview
Not against master (setting this up).