-
Notifications
You must be signed in to change notification settings - Fork 93
feat: multistream-select #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9c5b4d5
populate multistream-select
salmad3 7b60596
edits
salmad3 ad6b880
incorporate PR feedback and simplify
salmad3 e6b6fdb
Apply suggestions from code review
p-shahi 67d6f20
Rephrase title and include stream negotiation
mxinden 6fd1015
Fix multistream select not being a multiplexing protocol
mxinden 0fb3637
Rephrase central paragraph, mentioning stream protocol negotiation
mxinden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,23 @@ | ||
--- | ||
title: "Multistream Select" | ||
description: "" | ||
description: "Multistream Select is used to negotiate the protocol to be spoken on a connection or stream." | ||
weight: 26 | ||
--- | ||
|
||
Coming soon! | ||
## Overview | ||
|
||
[Multistream Select](https://github.com/multiformats/multistream-select) is a | ||
protocol negotiation protocol. It allows two peers to negotiate the next spoken | ||
protocol on a connection or stream. | ||
|
||
Peers use Multistream Select at various places to select the protocols to use on | ||
a libp2p connection or stream. Most prominently Multistream Select is used to | ||
select the [security](../../secure-comm/overview.md) followed by [stream | ||
multiplexing](../../multiplex/overview.md) protocol spoken on a connection. In | ||
addition it is used to select the application protocol (e.g. Kademlia) on each | ||
new stream on a given connection. The [protocol | ||
negotiation](../core-abstractions/connections#protocol-negotiation) and [upgrade | ||
process](../core-abstractions/connections#upgrading-connections) are explained | ||
further in the [connections document](../core-abstractions/connections.md). | ||
|
||
{{< alert icon="💡" context="note" text="See the multistream-select <a class=\"text-muted\" href=\"https://github.com/multiformats/multistream-select\">technical specification</a> for more details." />}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a sentence saying that it's also used to select application protocols spoken on streams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done with the last 3 commits.