Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team
When we added the semantic function of AVX512 instructions, we found that remill did not implement the reading of the k register. For example, the following AVX512 instruction:
In the above instruction, the k1 register is used as the result operand, and it is also indicated in docs/XED/xed.txt that the K mask register needs to be used:
But remill does not provide a method to read the K register.
To solve this problem, we need to add a variable to store the value of the K register in State.h, and add the size of the K register to the State variable.
I have submitted a PR and implemented the KMOVW instruction, hoping to provide valuable comments