Repository navigation
[swig] switch to SWIG_ADD_LIBRARY() in CMakeLists.txt (fixes #5586) - #5603
Conversation
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
jameslamb
changed the title
jameslamb
changed the title
There was a problem hiding this comment.
Thanks for this! I've modified the PR title so that it's more informative. PR titles become changelog items in this project's release notes (see https://github.com/microsoft/LightGBM/releases/tag/v3.3.3 for example), so we try be more specific than "fix CMakeLists.txt".
Please also fix the failing CI jobs, e.g. this one: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=13909&view=logs&j=535e9539-0564-5d34-2431-da2644b83c50&t=7cfc64df-bff4-5eef-5deb-8ea58a924da8.
CMake Error at /usr/local/share/cmake-3.23/Modules/UseSWIG.cmake:752 (message):
SWIG_ADD_LIBRARY: java;swig/lightgbmlib.i: unexpected arguments
Call Stack (most recent call first):
CMakeLists.txt:460 (swig_add_library)
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
|
@jameslamb |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks great, thanks very much for helping to resolve this deprecation warning so new releases of CMake won't disrupt LightGBM's JVM users. We hope you'll consider more contributions in the future.
|
Thanks for reviewing my PR! Hope to contribute more in the future! |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Signed-off-by: Shogo Hida shogo.hida@gmail.com
Fixes #5586