Skip to content

[swig] switch to SWIG_ADD_LIBRARY() in CMakeLists.txt (fixes #5586) #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 3 commits into from
Nov 27, 2022
Merged

[swig] switch to SWIG_ADD_LIBRARY() in CMakeLists.txt (fixes #5586) #5603

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffbcf2b
Fix CMakeLists.txt
shogohida Nov 24, 2022
e9710c3
Fix if conditions
shogohida Nov 25, 2022
a5c1fbc
Fix arguments of swig_add_library
shogohida Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ endif()
if(__INTEGRATE_OPENCL)
cmake_minimum_required(VERSION 3.11)
elseif(USE_GPU OR APPLE)
cmake_minimum_required(VERSION 3.2)
cmake_minimum_required(VERSION 3.8)
elseif(USE_CUDA OR USE_CUDA_EXP)
cmake_minimum_required(VERSION 3.16)
else()
cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.8)
endif()
Comment thread
shogohida marked this conversation as resolved.

project(lightgbm LANGUAGES C CXX)
Expand Down Expand Up @@ -457,7 +457,7 @@ if(USE_SWIG)
set_property(SOURCE swig/lightgbmlib.i PROPERTY CPLUSPLUS ON)
list(APPEND swig_options -package com.microsoft.ml.lightgbm)
set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}")
swig_add_module(_lightgbm_swig java swig/lightgbmlib.i)
swig_add_library(_lightgbm_swig java swig/lightgbmlib.i)
swig_link_libraries(_lightgbm_swig _lightgbm)
# needed to ensure Linux build does not have lib prefix specified twice, e.g. liblib_lightgbm_swig
set_target_properties(_lightgbm_swig PROPERTIES PREFIX "")
Expand Down