Refactor images lists and default mounts into base templates#3453
Refactor images lists and default mounts into base templates#3453AkihiroSuda merged 1 commit intolima-vm:masterfrom
Conversation
4387135 to
96d7c67
Compare
|
I wonder how we should deal with Maybe include some commented out sample values in the default template, but still use the base templates to get the images and mounts? |
96d7c67 to
cab7411
Compare
|
The tests also use the templates via filename locator ( Which means all the references to base templates should be relative locators: Which means the templates in So I think I should revert the change and reference the base templates via I would prefer to add |
Maybe |
I'll take a look, but this is now getting into scope-creep for a quick PR that I hoped to do on the side while working on something else. 😄 |
e1b3c84 to
7402238
Compare
|
This turned into a bit bigger PR than originally expected. I think it is getting close now, so please do another review. We could move other distro images to That may be enough of a reason to do it, but maybe it should be done at a later point in time, when we have some experience/feedback on the current refactoring? |
Also adds template://default/mounts to setup the default mounts globally. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
7402238 to
238a141
Compare
|
@AkihiroSuda PTAL! I hope CI will be green (except for the unrelated Windows failure). I will not be making any more changes today, and I hope this is close to "done" now. Hope I don't jinx it by marking it "Ready for review". 😄 |
|
Now Can we make it out of experimental now? |
Also adds template://default/mounts to setup the default mounts globally.
Closes #2418
If we decide to do this, then we should also create
images/*templates for the other distributions.