Skip to content

Finish $LIMA_TEMPLATES_PATH, add $LIMA_HOME/_templates#3482

Merged
jandubois merged 3 commits intolima-vm:masterfrom
jandubois:user-templates
May 1, 2025
Merged

Finish $LIMA_TEMPLATES_PATH, add $LIMA_HOME/_templates#3482
jandubois merged 3 commits intolima-vm:masterfrom
jandubois:user-templates

Conversation

@jandubois
Copy link
Member

@jandubois jandubois commented May 1, 2025

#3453 added support to locate templates via LIMA_TEMPLATES_PATH.

It was however not listing templates from the additional template directories for e.g. limactl start --list-templates and didn't include them in shell completions.

This PR adds the missing functionality, and also adds $LIMA_HOME/_templates as a default template search location if the directory exists and LIMA_TEMPLATES_PATH is not set.

In addition to making user templates addressable via template:// schema this also allows the user for example to create $LIMA_HOME/_templates/_default/mounts.yaml to override the default mounts used by all the builtin templates.

This PR intentionally uses 3 commits that are related, but independent. I don't think they should be squashed.

@jandubois jandubois added this to the v1.1.0 milestone May 1, 2025
@jandubois jandubois marked this pull request as draft May 1, 2025 01:32
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
…MPLATES_PATH

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@jandubois jandubois marked this pull request as ready for review May 1, 2025 03:10
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jandubois jandubois merged commit 2c48318 into lima-vm:master May 1, 2025
54 of 55 checks passed
@jandubois jandubois deleted the user-templates branch May 1, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants