Finish $LIMA_TEMPLATES_PATH, add $LIMA_HOME/_templates#3482
Merged
jandubois merged 3 commits intolima-vm:masterfrom May 1, 2025
Merged
Finish $LIMA_TEMPLATES_PATH, add $LIMA_HOME/_templates#3482jandubois merged 3 commits intolima-vm:masterfrom
jandubois merged 3 commits intolima-vm:masterfrom
Conversation
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
…MPLATES_PATH Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3453 added support to locate templates via
LIMA_TEMPLATES_PATH.It was however not listing templates from the additional template directories for e.g.
limactl start --list-templatesand didn't include them in shell completions.This PR adds the missing functionality, and also adds
$LIMA_HOME/_templatesas a default template search location if the directory exists andLIMA_TEMPLATES_PATHis not set.In addition to making user templates addressable via
template://schema this also allows the user for example to create$LIMA_HOME/_templates/_default/mounts.yamlto override the default mounts used by all the builtin templates.This PR intentionally uses 3 commits that are related, but independent. I don't think they should be squashed.