feat:Add tab suggestions for --set flag#5000
Open
Aneesh-Hegde wants to merge 1 commit into
Open
Conversation
Aneesh-Hegde
force-pushed
the
cli-tab-feature
branch
3 times, most recently
from
df2a0d4 to
b460887
Compare
AkihiroSuda
reviewed
May 18, 2026
| ".copyToHost", ".message", ".networks", ".env", ".param", ".dns", | ||
| ".hostResolver", ".propagateProxyEnv", ".caCerts", ".rosetta", ".plain", | ||
| ".timezone", ".nestedVirtualization", ".user", | ||
| } |
Member
There was a problem hiding this comment.
This should use reflection to avoid hard coding property names
Contributor
Author
There was a problem hiding this comment.
Done. Also for --set tab completion on slice fields like .images, .mounts, .additionalDisks, should we complete sub-fields using index syntax (.images[0].location=) or leave them as leaf completions
Aneesh-Hegde
force-pushed
the
cli-tab-feature
branch
from
b460887 to
76c3a61
Compare
AkihiroSuda
reviewed
May 18, 2026
| limatype.REVSSHFS, limatype.NINEP, | ||
| limatype.VIRTIOFS, limatype.WSLMount, | ||
| }, | ||
| ".mountInotify": {"true", "false"}, |
Member
There was a problem hiding this comment.
Use reflection to detect boolean property names
Signed-off-by: Aneesh-Hegde <aneeshhegde7110@gmail.com>
Aneesh-Hegde
force-pushed
the
cli-tab-feature
branch
from
76c3a61 to
1401485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4243
Demo:
https://github.com/user-attachments/assets/dcb63b0d-0804-43fe-901b-221518fd399a