Skip to content

NQuads parser doesn't pass test suite #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

tpluscode
Copy link
Collaborator

I've noticed before that NQuadRDFParser doesn't pass the NQuads parsing tests

For my JsonLD.Entities library I reimlpemented the parser from scratch but I think that this should be fixed here.

The first trivial fix was skipping comment lines and trailing comments.

This leaves 17 failing test cases, most around accepting invalid URIs. Do you have any plans here?


This may be controversial in the NuGet GitHub organization, but I'd replace packages.config etc. with paket so so that it's not necessary to commit all test case files. Paket can download and unzip them from w3c site.

@dnfclas
Copy link

dnfclas commented Mar 24, 2016

Hi @tpluscode, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Mar 25, 2016

@tpluscode, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@asbjornu
Copy link
Member

@tpluscode Excellent! But with pull requests from 2014 not being touched by @sblom, @jeffhandley or any other @NuGet maintainer, I'm not sure this is ever going to be merged. Perhaps we need to establish our own fork (under wikibus, for instance) and ship its assembly with Nancy.Rdf?

@tpluscode
Copy link
Collaborator Author

I was considering releasing an alternative NuGet package but it would be counterproductive in terms of how packages and community should work. Let's give the guys some time to react. With the CLA bot in place there seems to have been some changes to how .NET repositories work.

@tpluscode
Copy link
Collaborator Author

I'm closing this in favour of #14, which combines all fixes to JSON-LD and NQuads test suites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants