Upgrade Newtonsoft.Json and NQuads parsing fixes #14
Conversation
|
Hi @tpluscode, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@tpluscode, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
…ri-fix # Conflicts: # src/JsonLD/Core/JsonLdProcessor.cs # src/JsonLD/Core/JsonLdUtils.cs
tpluscode
force-pushed
the
upgrade-newtonsoft
branch
from
0bcae8a to
8c2fd0c
Compare
tpluscode
changed the title
|
@tpluscode As this pull request is close to 2 months old with no reaction from a human being and the repository hasn't been touched by a human for 1.5 years, how do you feel about my idea in #13 to fork this baby, so we can get things moving? |
|
Yes, this is a very disappointing turn of events. I'm not sure how this is going to work out. Would you publish an alternative package? Or just ship binaries with Nancy.RDF, possibly IL merged? Or maybe publish the package with same id on MyGet? |
|
Publishing with the same ID is impossible, I think. Only maintainers of the existing package (@sblom and @NuGet) can upload packages with the same ID. But we could either set up a public MyGet feed, mint a new ID or just package it with Nancy.Rdf. A new ID for the package and name for the forked repository could be |
| foreach (var c in ((string) input)) | ||
| { | ||
| if (c == ':') | ||
| hasColon = true; |
There was a problem hiding this comment.
style: add { }'s around this
|
@tpluscode thanks for the PR, it's good to see this library getting some help 😄 The changes and extra tests look good to me. |
|
@emgarten Yay, a human! 😄 What's the chance of getting this PR merged and released on NuGet? Can you help out with that? |
|
@asbjornu I'll take a look at building the nupkg for this with the changes next week. @johnataylor is going to review this also. |
|
@emgarten @johnataylor Brilliant! 😄 👍 |
|
I've merged the changes and created a 1.0.5 package here: https://www.myget.org/F/jsonld/api/v2/package/JsonLD/1.0.5 @asbjornu @tpluscode would you try out the new package and verify that it works for you? If it does I'll push it to nuget.org. |
|
@emgarten I've updated and it seems to work fine. Did you change the package name on purpose though? On NuGet it's json-ld.net and on MyGet it's JsonLd. I'd rather your didn't change that name. |
|
@tpluscode thanks for verifying and all the work on the PR, this is a great improvement 😄 I'll change before pushing this to nuget.org. I'm going to add a build script to this repo also to help with package creation and building. |
|
@emgarten Brilliant, thanks! |
Changes in Newtonsoft.Json >=6 break conversion from JSON-LD to RDF.
I'm also re-submitting the culture-specific fixes