Skip to content

Change target framework of tests to .NET 6 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Conversation

asbjornu
Copy link
Member

Change target framework of the test project from netcoreapp2.1 to net6.0. Hopefully this will make the tests succeed again.

asbjornu added 2 commits March 1, 2022 00:11
Change target framework of the test project from `netcoreapp2.1` to
`net6.0`.
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #133 (aee55e0) into main (80273e1) will decrease coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   68.79%   67.79%   -1.00%     
==========================================
  Files          23       23              
  Lines        4063     3866     -197     
  Branches     1033     1084      +51     
==========================================
- Hits         2795     2621     -174     
+ Misses       1124     1051      -73     
- Partials      144      194      +50     
Impacted Files Coverage Δ
src/json-ld.net/Core/Regex.cs 59.57% <0.00%> (-40.43%) ⬇️
src/json-ld.net/Core/RDFDatasetUtils.cs 50.53% <0.00%> (-4.31%) ⬇️
src/json-ld.net/Impl/TurtleRDFParser.cs 51.27% <0.00%> (-4.16%) ⬇️
src/json-ld.net/Core/JsonLdProcessor.cs 68.36% <0.00%> (-0.32%) ⬇️
src/json-ld.net/Core/Context.cs 89.27% <0.00%> (-0.29%) ⬇️
src/json-ld.net/Core/NormalizeUtils.cs 95.29% <0.00%> (-0.18%) ⬇️
src/json-ld.net/Util/JavaCompat.cs 70.43% <0.00%> (-0.16%) ⬇️
src/json-ld.net/Core/JsonLdApi.cs 84.84% <0.00%> (-0.13%) ⬇️
src/json-ld.net/Core/DocumentLoader.cs 100.00% <0.00%> (ø)
src/json-ld.net/Impl/TurtleTripleCallback.cs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80273e1...aee55e0. Read the comment docs.

Bump from `2.1-bionic` to `6.0-focal` in the Docker image.
@asbjornu asbjornu marked this pull request as ready for review February 28, 2022 23:30
Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass. Mission accomplished

@asbjornu asbjornu merged commit 8cacc06 into main Mar 1, 2022
@asbjornu asbjornu deleted the feature/net6-tests branch March 1, 2022 13:37
@asbjornu asbjornu mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants