Skip to content

Fix tests in 1.x #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Fix tests in 1.x #134

merged 4 commits into from
Mar 1, 2022

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Mar 1, 2022

This PR cherry-picks the commits from #133 to make the tests and release pipeline in the support/1.x branch successful.

asbjornu added 4 commits March 1, 2022 15:41
Change target framework of the test project from `netcoreapp2.1` to
`net6.0`.
# Conflicts:
#	.github/workflows/dotnet.yml
Bump from `2.1-bionic` to `6.0-focal` in the Docker image.
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (support/1.x@8c0934b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             support/1.x     #134   +/-   ##
==============================================
  Coverage               ?   67.74%           
==============================================
  Files                  ?       23           
  Lines                  ?     3866           
  Branches               ?     1084           
==============================================
  Hits                   ?     2619           
  Misses                 ?     1053           
  Partials               ?      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0934b...0ebc90e. Read the comment docs.

@asbjornu asbjornu marked this pull request as ready for review March 1, 2022 14:53
@asbjornu asbjornu requested a review from goofballLogic as a code owner March 1, 2022 14:53
@asbjornu asbjornu merged commit 681ed59 into support/1.x Mar 1, 2022
@asbjornu asbjornu deleted the feature/1x-net6-tests branch March 1, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant