-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[mlir][linalg][transform] Add some debug output to vectorization. (NFC) #66520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ingomueller-net
merged 1 commit into
llvm:main
from
ingomueller-net:transform-vectorize-debug-output
Sep 19, 2023
Merged
[mlir][linalg][transform] Add some debug output to vectorization. (NFC) #66520
ingomueller-net
merged 1 commit into
llvm:main
from
ingomueller-net:transform-vectorize-debug-output
Sep 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to understand what the problem is when vectorization of structured ops failes due to mismatching vector sizes.
@llvm/pr-subscribers-mlir-linalg @llvm/pr-subscribers-mlir ChangesThis helps to understand what the problem is when vectorization of structured ops failes due to mismatching vector sizes.Full diff: https://github.com/llvm/llvm-project/pull/66520.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp b/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
index f873bd0e0b68e43..51a83c35e4cda09 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
@@ -924,7 +924,6 @@ getTensorExtractMemoryAccessPattern(tensor::ExtractOp extractOp,
targetShape.back() == 1)
return VectorMemoryAccessKind::Gather;
-
// 2. Assume that it's a gather load when reading _from_ a tensor for which
// the trailing dimension is 1, e.g. `tensor<1x4x1xi32>`.
// TODO: Relax this condition.
@@ -1484,6 +1483,10 @@ static LogicalResult vectorizeDynamicLinalgOpPrecondition(linalg::LinalgOp op) {
static LogicalResult
isValidMaskedInputVector(ArrayRef<int64_t> shape,
ArrayRef<int64_t> inputVectorSizes) {
+ LDBG("Iteration space static sizes:");
+ LLVM_DEBUG(llvm::interleaveComma(shape, llvm::dbgs()));
+ LLVM_DEBUG(llvm::dbgs() << "\n");
+
if (inputVectorSizes.size() != shape.size()) {
LDBG("Input vector sizes don't match the number of loops");
return failure();
|
zero9178
added a commit
to zero9178/llvm-project
that referenced
this pull request
Sep 15, 2023
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with directory suffices such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as llvm#66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
zero9178
added a commit
that referenced
this pull request
Sep 15, 2023
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with very common directory suffixes such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as #66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with very common directory suffixes such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as llvm#66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
nicolasvasilache
approved these changes
Sep 19, 2023
This was referenced Sep 19, 2023
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with very common directory suffixes such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as llvm#66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with very common directory suffixes such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as llvm#66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to understand what the problem is when vectorization of structured ops failes due to mismatching vector sizes.