[clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings

[kadircet]

No description provided.

[VitaNuo]

I believe you could move this passage into the handling of standard headers in shouldIgnore. Then the below could also be simplified.

[kadircet]

ATM shouldIgnore is operating on an include_cleaner::Header (for good reason, as we need to use it both for missing and unused includes). Hence we can't really go from a physical Header to a stdlib one inside shouldIgnore. We can add overloads to accept both a Header and an Include, then we can move this logic into the relevant overload, but I don't think that'll be any cleaner.

Did you have something else in mind?

[VitaNuo]

Ok, thanks, then what about something like (apologies for small mistakes, just typing into the comment window):

include_cleaner::Header getHeader(include_cleaner::Include I) {
    auto StdHeader = tooling::stdlib::Header::named(I.quote(), PP->getLangOpts().CPlusPlus ? tooling::stdlib::Lang::CXX :  tooling::stdlib::Lang::C);

   if (StdHeader) 
      return include_cleaner::Header(*StdHeader);
   return include_cleaner::Header(I.Resolved);
}

auto Header = getHeader(I);
if (shouldIgnore(Header))
 continue;

I'm trying to simplify the flow in the check method, as it seems like it's getting bogged down in implementation details. WDYT?

[kadircet]

I think that would be even better, but it would be a regression to current users. ATM this code is checking both the StdHeader and the Resolved header. In your suggestion we would only check for one or the other.

[VitaNuo]

Thank you. What was the bug that triggered this? It seems like the verbatim headers were only matched if they were specified as quoted in the ignore config?

[kadircet]

Thank you. What was the bug that triggered this? It seems like the verbatim headers were only matched if they were specified as quoted in the ignore config?

I just noticed it while trying to fix an internal issue.

[PiotrZSL]

Overall looks fine, but please update release notes for this (update current entry or even merge them together instead of adding new one). And make sure that there is a commit description for this change when committing, instead of just having only a title.

[kadircet]

Overall looks fine, but please update release notes for this (update current entry or even merge them together instead of adding new one). And make sure that there is a commit description for this change when committing, instead of just having only a title.

done.