Skip to content

[RISCV][ISel] Fix comment to match direction of predicate in code. NFC. - #68248

Merged
michaelmaitland merged 1 commit into
llvm:mainfrom
michaelmaitland:fix-pred-comment
Oct 4, 2023
Merged

[RISCV][ISel] Fix comment to match direction of predicate in code. NFC.#68248
michaelmaitland merged 1 commit into
llvm:mainfrom
michaelmaitland:fix-pred-comment

Conversation

@michaelmaitland

Copy link
Copy Markdown
Contributor

The comment says something different than what is happening in the code. This patch aligns the comment with the code.

@llvmbot

llvmbot commented Oct 4, 2023

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-backend-risc-v

Changes

The comment says something different than what is happening in the code. This patch aligns the comment with the code.


Full diff: https://github.com/llvm/llvm-project/pull/68248.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVISelLowering.cpp (+1-1)
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index d72ec1591f9b0b3..4376969c0e5ae73 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -2128,7 +2128,7 @@ static void translateSetCCForBranch(const SDLoc &DL, SDValue &LHS, SDValue &RHS,
       }
       break;
     case ISD::SETLT:
-      // Convert X < 1 to 0 <= X.
+      // Convert X < 1 to 0 >= X.
       if (C == 1) {
         RHS = LHS;
         LHS = DAG.getConstant(0, DL, RHS.getValueType());

@topperc topperc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants