Skip to content

[NVPTX] Fixed few more corner cases for v4i8 lowering. #69263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

[NVPTX] Fixed few more corner cases for v4i8 lowering. #69263

merged 2 commits into from
Oct 17, 2023

Conversation

Artem-B
Copy link
Member

@Artem-B Artem-B commented Oct 16, 2023

Fixes #69124

@Artem-B Artem-B requested review from d0k and ThomasRaoux October 16, 2023 23:06
@Artem-B Artem-B marked this pull request as draft October 16, 2023 23:08
@Artem-B
Copy link
Member Author

Artem-B commented Oct 16, 2023 •
edited
Loading

Hold off on review. The patch still needs to have setcc fixed.

ThomasRaoux
ThomasRaoux approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Artem-B Artem-B self-assigned this Oct 16, 2023
@Artem-B Artem-B marked this pull request as ready for review October 16, 2023 23:23
@Artem-B Artem-B merged commit b337237 into llvm:main Oct 17, 2023
@Artem-B Artem-B deleted the v4i8-pr69124 branch October 17, 2023 18:06
@madhur13490 madhur13490 mentioned this pull request Oct 20, 2023
Closed
@banach-space banach-space mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0k d0k d0k approved these changes

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

Assignees

@Artem-B Artem-B

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 x i8 u/srem causes internal compiler error in nvptx instruction selection
3 participants
@Artem-B @d0k @ThomasRaoux