[TableGen] Fix minor index bugs in PseudoLoweringEmitter #81605
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This commit fixes some minor indices bugs in PseudoLoweringEmitter.cpp. I don't believe these bugs would have had much of an effect previously but they were causing some issues with some refactoring work with ".w" and ".n" operands I am working on currently.
AlfieRichardsArm
force-pushed
the
SDCOMP-63871-.w-.n-syntax
branch
from
fb9a9e9 to
7aefdbe
Compare
|
@s-barannikov I will update this patch with your suggestions from the other so you dont have to repeat yourself |
|
@AlfieRichardsArm Is this still relevant? |
|
Hi @s-barannikov, Apologies, I have moved to working in GCC so haven’t kept up with this patch. I think this patch can be closed. These bugs likely still exist, but only came up when I was trying to make .n and .w optional operands, which is indefinitely paused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes some minor indices bugs in PseudoLoweringEmitter.cpp.
I don't believe these bugs would have had much of an effect previously but they were causing some issues with some refactoring work regarding ARM thumb ".w" and ".n" operands I am working on currently.