[AVR] Remove earlyclobber from LDDRdPtrQ #85277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @benshi001, when you have a moment 🙂 |
|
Thanks for your great work! It looks good to me. Just remove |
benshi001
approved these changes
Mar 15, 2024
LDDRdPtrQ was marked as earlyclobber, which doesn't play well with GreedyRA (which can generate this instruction through `loadRegFromStackSlot()`). This seems to be the same case as: https://github.com/llvm/llvm-project/blob/a99b912c9b74f6ef91786b4dfbc25160c27d3b41/llvm/lib/Target/AVR/AVRInstrInfo.td#L1421 Closes #81911.
|
Done! 🚀 I've also tested the changes by compiling rustc locally and simavr-ing a few firmwares, and everything seems to be working correctly 🙂 |
This was referenced Mar 15, 2024
Merged
Error: Command failed due to missing milestone. |
|
Ah, by the way, sorry - I haven't noticed that you've proposed that description after |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Mar 16, 2024
LDDRdPtrQ was marked as `earlyclobber`, which doesn't play well with GreedyRA (which can generate this instruction through `loadRegFromStackSlot()`). This seems to be the same case as: https://github.com/llvm/llvm-project/blob/a99b912c9b74f6ef91786b4dfbc25160c27d3b41/llvm/lib/Target/AVR/AVRInstrInfo.td#L1421 Closes llvm#81911. (cherry picked from commit 328cb9b)
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
Mar 22, 2024
Bump the toolchain version to pull in a fix for a recently discovered miscompilation issue [1]. [1]: llvm/llvm-project#85277
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
Mar 22, 2024
Bump the toolchain version to pull in a fix for a recently discovered miscompilation issue [1]. [1]: llvm/llvm-project#85277
tippfehlr
pushed a commit
to tippfehlr/avr-hal
that referenced
this pull request
Mar 24, 2024
Bump the toolchain version to pull in a fix for a recently discovered miscompilation issue [1]. [1]: llvm/llvm-project#85277
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDDRdPtrQ was marked as earlyclobber, which doesn't play well with GreedyRA (which can generate this instruction through
loadRegFromStackSlot()).This seems to be the same case as:
llvm-project/llvm/lib/Target/AVR/AVRInstrInfo.td
Line 1421 in a99b912
Closes #81911.