[AMDGPU] Extend permlane16, permlanex16 and permlane64 intrinsic lowering for generic types #92725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for generic types
vikramRH
requested review from
jayfoad,
arsenm,
b-sumner,
pravinjagtap and
cdevadas
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vikramRH
force-pushed
the
permlane_generic
branch
from
db19330 to
881e116
Compare
…ring for generic types
arsenm
reviewed
May 20, 2024
| Register Src1Cast = | ||
| MRI.getType(Src1).isScalar() | ||
| ? Src1 | ||
| : B.buildBitcast(LLT::scalar(Size), Src2).getReg(0); |
There was a problem hiding this comment.
Like the other patch, shouldn't need any bitcasts
There was a problem hiding this comment.
Yes, I will take over the changes from #89217 once finalized,
|
arsenm
reviewed
May 29, 2024
vikramRH
changed the title
arsenm
approved these changes
Jun 25, 2024
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…ring for generic types (llvm#92725) These are incremental changes over llvm#89217 , with core logic being the same. This patch along with llvm#89217 and llvm#91190 should get us ready to enable 64 bit optimizations in atomic optimizer.
jrbyrnes
pushed a commit
to jrbyrnes/llvm-project
that referenced
this pull request
Aug 16, 2024
…ring for generic types (llvm#92725) These are incremental changes over llvm#89217 , with core logic being the same. This patch along with llvm#89217 and llvm#91190 should get us ready to enable 64 bit optimizations in atomic optimizer. Change-Id: Ief70422a47461606c29134b217f40204ee4a198b
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Sep 11, 2024
…ring for generic types (llvm#92725) These are incremental changes over llvm#89217 , with core logic being the same. This patch along with llvm#89217 and llvm#91190 should get us ready to enable 64 bit optimizations in atomic optimizer. Change-Id: Ief70422a47461606c29134b217f40204ee4a198b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kindly review only top commits here (i.e commits except the first). These are incremental changes over #89217 , with core logic being the same. Only reason to split these up into separate PR is for ease of review.
This patch along with #89217 and #91190 should get us ready to enable 64 bit optimizations in atomic optimizer.