Add upgrade howto#58
Merged
Merged
Conversation
This was referenced Feb 8, 2021
OndraM
commented
Feb 8, 2021
|
|
||
| ```diff | ||
| - "lmc/coding-standard": "^2.1", | ||
| + "lmc/coding-standard": "^3.0", |
Contributor
Author
There was a problem hiding this comment.
If you want to use it already until the 3.0 version is actually released, one must obviously use branch constrain (dev-feature/ecs-9 etc.)
OndraM
force-pushed
the
feature/upgrade-howto
branch
2 times, most recently
from
b104641 to
4589f53
Compare
MortalFlesh
approved these changes
Feb 8, 2021
legendik
approved these changes
Feb 8, 2021
jirinovak
approved these changes
Feb 8, 2021
OndraM
force-pushed
the
feature/upgrade-howto
branch
from
4589f53 to
997cdf8
Compare
minarikv
reviewed
Feb 9, 2021
| Because of the nature of how ECS process the configuration (which is, in fact, the behavior of underlying | ||
| symfony/dependency-injection), you must follow the order in which you add your customizations. | ||
|
|
||
| In your `ecs.php` add import of the lmc/coding-standard **after** you add `skip` parameter but **before** your custom code-style ajdustements: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step-by-step how to upgrade codestyle config to PHP format. Ref. #56 #51 .
Real-word example of such upgrade done by this guide: https://github.com/lmc-eu/steward/pull/270/files