Upgrade to ECS 9 with PHP config #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
requested review from
dudla,
florianjiri,
hokypierce,
jirinovak,
kdosiodjinud,
legendik,
MarketaSebkova,
MortalFlesh and
obelixicek
This was
linked to
issues
Feb 4, 2021
|
|
Co-authored-by: Jakub Pilař <[email protected]>
Merged
This was referenced Feb 8, 2021
Merged
|
Also to clarify: no new rules were added, it is still configured exactly the same as previously. (There is a separate issue for adding new check from those newly added to php-cs-fixer etc.: #52 ) |
legendik
approved these changes
Feb 8, 2021
jirinovak
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit reworked #54 (thx @PilarJ for the initial implementation!). Fixes #50 and #51.
The main issue is with readability. I personally don't like the PHP config that much (there is so much noise with repeated
$services->set()etc.), the YAML provided IMHO nice abstraction and much cleaner notation 🙄 . However this is how things are and we have to live with it 🤷.I at least tried encapsulate "rules configuration" and "parameters configuration" into anonymous functions, so that there is at least some structure in the config, what do you think?
BTW for codestyle of the respective projects this is not such issue, because the configuration will usually be just an import of this codestyle and few lines of customizations. Step-by-step upgrade guide for the projects is here.